[PATCH] dmaengine: idxd: clear block on fault flag when clear wq

[PATCH] dmaengine: idxd: clear block on fault flag when clear wq

[Dave Jiang]

The block on fault flag is not cleared when we disable or reset wq. This
causes it to remain set if the user does not clear it on the next
configuration load. Add clear of flag in dxd_wq_disable_cleanup()
routine.

Fixes: da32b28c95a7 ("dmaengine: idxd: cleanup workqueue config after disabling")
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 drivers/dma/idxd/device.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
index 420b93fe5feb..d0b5222da0d9 100644
--- a/drivers/dma/idxd/device.c
+++ b/drivers/dma/idxd/device.c
@@ -396,6 +396,7 @@ void idxd_wq_disable_cleanup(struct idxd_wq *wq)
 	wq->priority = 0;
 	wq->ats_dis = 0;
 	clear_bit(WQ_FLAG_DEDICATED, &wq->flags);
+	clear_bit(WQ_FLAG_BLOCK_ON_FAULT, &wq->flags);
 	memset(wq->name, 0, WQ_NAME_SIZE);
 }
 

Re: [PATCH] dmaengine: idxd: clear block on fault flag when clear wq

[Vinod Koul]

On 03-08-21, 15:37, Dave Jiang wrote:
> The block on fault flag is not cleared when we disable or reset wq. This
> causes it to remain set if the user does not clear it on the next
> configuration load. Add clear of flag in dxd_wq_disable_cleanup()
> routine.

Applied, thanks

-- 
~Vinod