[PATCH] dmaengine: loongson: Use %p for pointer formatting

[PATCH] dmaengine: loongson: Use %p for pointer formatting

[Sebastian Andrzej Siewior]

The %pK format modifier was meant for /proc kind of output, not general
printk output. Since commit ad67b74d2469d ("printk: hash addresses
printed with %p") pointers are hashed by default and the behaviour can
be controller by `hash_pointers' boot argument.
The policy on %p is to not introduce new ones. This is the only pointer
output in the driver.

Remove the pointer formating from debug output.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/dma/loongson/loongson2-apb-cmc-dma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/loongson/loongson2-apb-cmc-dma.c b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
index 1c9a542edc859..27f8f7a5738d9 100644
--- a/drivers/dma/loongson/loongson2-apb-cmc-dma.c
+++ b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
@@ -337,7 +337,6 @@ static void loongson2_cmc_dma_issue_pending(struct dma_chan *chan)
 	guard(spinlock_irqsave)(&lchan->vchan.lock);
 
 	if (vchan_issue_pending(&lchan->vchan) && !lchan->desc) {
-		dev_dbg(chan2dev(lchan), "vchan %pK: issued\n", &lchan->vchan);
 		loongson2_cmc_dma_start_transfer(lchan);
 	}
 }
-- 
2.55.0

Re: [PATCH] dmaengine: loongson: Use %p for pointer formatting

[Frank Li]

On Fri, Sep 18, 2026 at 12:34:09PM +0200, Sebastian Andrzej Siewior wrote:
> The %pK format modifier was meant for /proc kind of output, not general
> printk output. Since commit ad67b74d2469d ("printk: hash addresses
> printed with %p") pointers are hashed by default and the behaviour can
> be controller by `hash_pointers' boot argument.
> The policy on %p is to not introduce new ones. This is the only pointer
> output in the driver.
>
> Remove the pointer formating from debug output.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  drivers/dma/loongson/loongson2-apb-cmc-dma.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/loongson/loongson2-apb-cmc-dma.c b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> index 1c9a542edc859..27f8f7a5738d9 100644
> --- a/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> +++ b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> @@ -337,7 +337,6 @@ static void loongson2_cmc_dma_issue_pending(struct dma_chan *chan)
>  	guard(spinlock_irqsave)(&lchan->vchan.lock);
>
>  	if (vchan_issue_pending(&lchan->vchan) && !lchan->desc) {
> -		dev_dbg(chan2dev(lchan), "vchan %pK: issued\n", &lchan->vchan);

You remove whole dev_dbg(), but commit message said Use %p

Frank
>  		loongson2_cmc_dma_start_transfer(lchan);
>  	}
>  }
> --
> 2.55.0
>

Re: [PATCH] dmaengine: loongson: Use %p for pointer formatting

[Sebastian Andrzej Siewior]

On 2026-09-18 12:06:41 [-0500], Frank Li wrote:
> On Fri, Sep 18, 2026 at 12:34:09PM +0200, Sebastian Andrzej Siewior wrote:
> > The %pK format modifier was meant for /proc kind of output, not general
> > printk output. Since commit ad67b74d2469d ("printk: hash addresses
> > printed with %p") pointers are hashed by default and the behaviour can
> > be controller by `hash_pointers' boot argument.
> > The policy on %p is to not introduce new ones. This is the only pointer
> > output in the driver.
> >
> > Remove the pointer formating from debug output.
> >
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> >  drivers/dma/loongson/loongson2-apb-cmc-dma.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/dma/loongson/loongson2-apb-cmc-dma.c b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> > index 1c9a542edc859..27f8f7a5738d9 100644
> > --- a/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> > +++ b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> > @@ -337,7 +337,6 @@ static void loongson2_cmc_dma_issue_pending(struct dma_chan *chan)
> >  	guard(spinlock_irqsave)(&lchan->vchan.lock);
> >
> >  	if (vchan_issue_pending(&lchan->vchan) && !lchan->desc) {
> > -		dev_dbg(chan2dev(lchan), "vchan %pK: issued\n", &lchan->vchan);
> 
> You remove whole dev_dbg(), but commit message said Use %p

I redid based on feedback before submitting and forgot to update the
subject. Are you fine with removing it?

> Frank
> >  		loongson2_cmc_dma_start_transfer(lchan);
> >  	}
> >  }

Sebastian

Re: [PATCH] dmaengine: loongson: Use %p for pointer formatting

[Frank Li]

On Fri, Sep 18, 2026 at 07:17:30PM +0200, Sebastian Andrzej Siewior wrote:
> On 2026-09-18 12:06:41 [-0500], Frank Li wrote:
> > On Fri, Sep 18, 2026 at 12:34:09PM +0200, Sebastian Andrzej Siewior wrote:
> > > The %pK format modifier was meant for /proc kind of output, not general
> > > printk output. Since commit ad67b74d2469d ("printk: hash addresses
> > > printed with %p") pointers are hashed by default and the behaviour can
> > > be controller by `hash_pointers' boot argument.
> > > The policy on %p is to not introduce new ones. This is the only pointer
> > > output in the driver.
> > >
> > > Remove the pointer formating from debug output.
> > >
> > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > > ---
> > >  drivers/dma/loongson/loongson2-apb-cmc-dma.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/dma/loongson/loongson2-apb-cmc-dma.c b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> > > index 1c9a542edc859..27f8f7a5738d9 100644
> > > --- a/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> > > +++ b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> > > @@ -337,7 +337,6 @@ static void loongson2_cmc_dma_issue_pending(struct dma_chan *chan)
> > >  	guard(spinlock_irqsave)(&lchan->vchan.lock);
> > >
> > >  	if (vchan_issue_pending(&lchan->vchan) && !lchan->desc) {
> > > -		dev_dbg(chan2dev(lchan), "vchan %pK: issued\n", &lchan->vchan);
> >
> > You remove whole dev_dbg(), but commit message said Use %p
>
> I redid based on feedback before submitting and forgot to update the
> subject. Are you fine with removing it?

I am fine to remove it.

Frank
>
> > Frank
> > >  		loongson2_cmc_dma_start_transfer(lchan);
> > >  	}
> > >  }
>
> Sebastian