Re: [PATCH v7 10/24] dmaengine: ste_dma40: Fix probe IRQ leak

[Frank Li <Frank.li@oss.nxp.com>]

On Sun, Sep 27, 2026 at 11:03:23AM +0200, Linus Walleij wrote:
> d40_probe() registers the hardware interrupt before several later probe
> steps that can fail. Those error paths jump to destroy_cache without
> freeing the IRQ, leaving the handler registered after probe resources have
> been released.
>
> Route failures after a successful IRQ request through a dedicated cleanup
> label. Keep the request before DMAengine registration because that
> registration publishes channels to clients.
>
> Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3")
> Reported-by: sashiko-bot@kernel.org
> Closes: https://lore.kernel.org/dmaengine/20260618051539.15E201F000E9@smtp.kernel.org/
> Assisted-by: LLM
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/ste_dma40.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> index 3bf89b057ccf..4c545a947264 100644
> --- a/drivers/dma/ste_dma40.c
> +++ b/drivers/dma/ste_dma40.c
> @@ -3846,18 +3846,20 @@ static int __init d40_probe(struct platform_device *pdev)
>  	}
>  	ret = d40_dmaengine_init(base, num_reserved_chans);
>  	if (ret)
> -		goto destroy_cache;
> +		goto release_irq;
>
>  	ret = of_dma_controller_register(np, d40_xlate, NULL);
>  	if (ret) {
>  		dev_err(dev,
>  			"could not register of_dma_controller\n");
> -		goto destroy_cache;
> +		goto release_irq;
>  	}
>
>  	dev_info(base->dev, "initialized\n");
>  	return 0;
>
> + release_irq:
> +	free_irq(base->irq, base);
>   destroy_cache:
>  	if (base->lcla_pool.dma_addr)
>  		dma_unmap_single(base->dev, base->lcla_pool.dma_addr,
>
> --
> 2.55.0
>