* [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var
@ 2018-05-21 1:20 yaochuhong
2018-05-21 1:20 ` [PATCH 2/3] fix Coding Style yaochuhong
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: yaochuhong @ 2018-05-21 1:20 UTC (permalink / raw)
To: shijith.thotton; +Cc: dev, yaochuhong
Signed-off-by: yaochuhong <ych@panath.cn>
---
drivers/net/liquidio/lio_ethdev.c | 6 ++++++
1 file changed, 6 insertions(+)
mode change 100644 => 100755 drivers/net/liquidio/lio_ethdev.c
diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
old mode 100644
new mode 100755
index 0e0b5d8..bd47911
--- a/drivers/net/liquidio/lio_ethdev.c
+++ b/drivers/net/liquidio/lio_ethdev.c
@@ -1405,6 +1405,12 @@ struct rte_lio_xstats_name_off {
/* Configure RSS if device configured with multiple RX queues. */
lio_dev_mq_rx_configure(eth_dev);
+ /* Before update the link info, set link_status64 to 0,
+ * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained,
+ * and lio_dev->intf_open will be set to 0.
+ */
+ lio_dev->linfo.link.link_status64 = 0;
+
/* start polling for lsc */
ret = rte_eal_alarm_set(LIO_LSC_TIMEOUT,
lio_sync_link_state_check,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] fix Coding Style 2018-05-21 1:20 [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var yaochuhong @ 2018-05-21 1:20 ` yaochuhong 2018-05-21 1:20 ` [PATCH 3/3] add signoff yaochuhong 2018-05-21 6:55 ` [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var Stephen Hemminger 2 siblings, 0 replies; 6+ messages in thread From: yaochuhong @ 2018-05-21 1:20 UTC (permalink / raw) To: shijith.thotton; +Cc: dev, yaochuhong --- drivers/net/liquidio/lio_ethdev.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) mode change 100755 => 100644 drivers/net/liquidio/lio_ethdev.c diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c old mode 100755 new mode 100644 index bd47911..0a6eb55 --- a/drivers/net/liquidio/lio_ethdev.c +++ b/drivers/net/liquidio/lio_ethdev.c @@ -1405,10 +1405,7 @@ struct rte_lio_xstats_name_off { /* Configure RSS if device configured with multiple RX queues. */ lio_dev_mq_rx_configure(eth_dev); - /* Before update the link info, set link_status64 to 0, - * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, - * and lio_dev->intf_open will be set to 0. - */ + /* Before update the link info, must set link_status64 to 0. */ lio_dev->linfo.link.link_status64 = 0; /* start polling for lsc */ -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] add signoff 2018-05-21 1:20 [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var yaochuhong 2018-05-21 1:20 ` [PATCH 2/3] fix Coding Style yaochuhong @ 2018-05-21 1:20 ` yaochuhong 2018-05-21 10:07 ` Ferruh Yigit 2018-05-21 6:55 ` [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var Stephen Hemminger 2 siblings, 1 reply; 6+ messages in thread From: yaochuhong @ 2018-05-21 1:20 UTC (permalink / raw) To: shijith.thotton; +Cc: dev, yaochuhong Signed-off-by: yaochuhong <ych@panath.cn> --- drivers/net/liquidio/lio_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c index 0a6eb55..a6a37c8 100644 --- a/drivers/net/liquidio/lio_ethdev.c +++ b/drivers/net/liquidio/lio_ethdev.c @@ -1405,7 +1405,7 @@ struct rte_lio_xstats_name_off { /* Configure RSS if device configured with multiple RX queues. */ lio_dev_mq_rx_configure(eth_dev); - /* Before update the link info, must set link_status64 to 0. */ + /* Before update the link info, must set linfo.link.link_status64 to 0. */ lio_dev->linfo.link.link_status64 = 0; /* start polling for lsc */ -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] add signoff 2018-05-21 1:20 ` [PATCH 3/3] add signoff yaochuhong @ 2018-05-21 10:07 ` Ferruh Yigit 2018-05-21 10:11 ` Yao chuhong 0 siblings, 1 reply; 6+ messages in thread From: Ferruh Yigit @ 2018-05-21 10:07 UTC (permalink / raw) To: yaochuhong, shijith.thotton; +Cc: dev On 5/21/2018 2:20 AM, yaochuhong wrote: > Signed-off-by: yaochuhong <ych@panath.cn> Hi Yao, Thanks for contribution. Can you please send this as a single patch, and for sign off please follow Signed-off-by: Name Surname <e-mail@all_lower.case> There is some documentation about how to prepare and send a patch that may help: https://dpdk.org/doc/guides/contributing/patches.html > --- > drivers/net/liquidio/lio_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c > index 0a6eb55..a6a37c8 100644 > --- a/drivers/net/liquidio/lio_ethdev.c > +++ b/drivers/net/liquidio/lio_ethdev.c > @@ -1405,7 +1405,7 @@ struct rte_lio_xstats_name_off { > /* Configure RSS if device configured with multiple RX queues. */ > lio_dev_mq_rx_configure(eth_dev); > > - /* Before update the link info, must set link_status64 to 0. */ > + /* Before update the link info, must set linfo.link.link_status64 to 0. */ > lio_dev->linfo.link.link_status64 = 0; > > /* start polling for lsc */ > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] add signoff 2018-05-21 10:07 ` Ferruh Yigit @ 2018-05-21 10:11 ` Yao chuhong 0 siblings, 0 replies; 6+ messages in thread From: Yao chuhong @ 2018-05-21 10:11 UTC (permalink / raw) To: Ferruh Yigit, shijith.thotton; +Cc: dev Ok, I see. 搜索 复制 ------------------ Original ------------------ From: "Ferruh Yigit"; Date: 2018年5月21日(星期一) 晚上6:07 To: "yaochuhong"; "shijith.thotton"; Cc: "dev"; Subject: Re: [dpdk-dev] [PATCH 3/3] add signoff On 5/21/2018 2:20 AM, yaochuhong wrote: > Signed-off-by: yaochuhong <ych@panath.cn> Hi Yao, Thanks for contribution. Can you please send this as a single patch, and for sign off please follow Signed-off-by: Name Surname <e-mail@all_lower.case> There is some documentation about how to prepare and send a patch that may help: https://dpdk.org/doc/guides/contributing/patches.html > --- > drivers/net/liquidio/lio_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c > index 0a6eb55..a6a37c8 100644 > --- a/drivers/net/liquidio/lio_ethdev.c > +++ b/drivers/net/liquidio/lio_ethdev.c > @@ -1405,7 +1405,7 @@ struct rte_lio_xstats_name_off { > /* Configure RSS if device configured with multiple RX queues. */ > lio_dev_mq_rx_configure(eth_dev); > > - /* Before update the link info, must set link_status64 to 0. */ > + /* Before update the link info, must set linfo.link.link_status64 to 0. */ > lio_dev->linfo.link.link_status64 = 0; > > /* start polling for lsc */ > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var 2018-05-21 1:20 [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var yaochuhong 2018-05-21 1:20 ` [PATCH 2/3] fix Coding Style yaochuhong 2018-05-21 1:20 ` [PATCH 3/3] add signoff yaochuhong @ 2018-05-21 6:55 ` Stephen Hemminger 2 siblings, 0 replies; 6+ messages in thread From: Stephen Hemminger @ 2018-05-21 6:55 UTC (permalink / raw) To: yaochuhong; +Cc: shijith.thotton, dev On Mon, 21 May 2018 09:20:53 +0800 yaochuhong <ych@panath.cn> wrote: > Signed-off-by: yaochuhong <ych@panath.cn> > --- > drivers/net/liquidio/lio_ethdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > mode change 100644 => 100755 drivers/net/liquidio/lio_ethdev.c > > diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c > old mode 100644 > new mode 100755 > index 0e0b5d8..bd47911 > --- a/drivers/net/liquidio/lio_ethdev.c > +++ b/drivers/net/liquidio/lio_ethdev.c > @@ -1405,6 +1405,12 @@ struct rte_lio_xstats_name_off { > /* Configure RSS if device configured with multiple RX queues. */ > lio_dev_mq_rx_configure(eth_dev); > > + /* Before update the link info, set link_status64 to 0, > + * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, > + * and lio_dev->intf_open will be set to 0. > + */ > + lio_dev->linfo.link.link_status64 = 0; > + > /* start polling for lsc */ > ret = rte_eal_alarm_set(LIO_LSC_TIMEOUT, > lio_sync_link_state_check, Your mail system or editor is converting tabs to spaces. Please run checkpatch on your submissions. ### [dpdk-dev] [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files #88: FILE: drivers/net/liquidio/lio_ethdev.c ERROR:TRAILING_WHITESPACE: trailing whitespace #97: FILE: drivers/net/liquidio/lio_ethdev.c:1409: + * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, $ WARNING:LONG_LINE_COMMENT: line over 80 characters #97: FILE: drivers/net/liquidio/lio_ethdev.c:1409: + * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, WARNING:LEADING_SPACE: please, no spaces at the start of a line #100: FILE: drivers/net/liquidio/lio_ethdev.c:1412: + lio_dev->linfo.link.link_status64 = 0;$ ERROR:TRAILING_WHITESPACE: trailing whitespace #101: FILE: drivers/net/liquidio/lio_ethdev.c:1413: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #101: FILE: drivers/net/liquidio/lio_ethdev.c:1413: + $ total: 3 errors, 3 warnings, 0 checks, 12 lines checked ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-21 10:11 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-05-21 1:20 [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var yaochuhong 2018-05-21 1:20 ` [PATCH 2/3] fix Coding Style yaochuhong 2018-05-21 1:20 ` [PATCH 3/3] add signoff yaochuhong 2018-05-21 10:07 ` Ferruh Yigit 2018-05-21 10:11 ` Yao chuhong 2018-05-21 6:55 ` [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var Stephen Hemminger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox