From: Stephen Hemminger <stephen@networkplumber.org>
To: Weijun Pan <wpan3636@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] test: parenthesize assertion macro parameters
Date: Wed, 29 Apr 2026 07:26:10 -0700 [thread overview]
Message-ID: <20260429072610.1f87ad78@phoenix.local> (raw)
In-Reply-To: <20260427171714.9887-1-wpan3636@gmail.com>
On Mon, 27 Apr 2026 12:17:13 -0500
Weijun Pan <wpan3636@gmail.com> wrote:
> Some test assertion macros use parameters directly in expressions,
> which can lead to unexpected evaluation due to operator precedence
> after macro substitution.
>
> Fix this by parenthesizing macro parameters and the resulting
> expressions in rte_test.h and app/test/test.h.
>
> This is a test macro robustness fix and does not fix a runtime issue
> in DPDK, so no Fixes or stable tags are added.
>
> Bugzilla ID: 1925
>
> Signed-off-by: Weijun Pan <wpan3636@gmail.com>
This is not critical path code, and there is secondary problem
of arguements being evaluated multiple times. Perhaps use helper
functions instead.
For test.h do this. The rte_test.h part is correct.
Let me split them and send a followup
next prev parent reply other threads:[~2026-04-29 14:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 16:48 [PATCH] test: parenthesize assertion macro parameters Weijun Pan
2026-04-24 9:48 ` Marat Khalili
2026-04-24 11:12 ` Marat Khalili
2026-04-27 17:17 ` [PATCH v2] " Weijun Pan
2026-04-29 12:31 ` Marat Khalili
2026-04-29 14:26 ` Stephen Hemminger [this message]
2026-04-29 14:42 ` [PATCH 0/2] test: clean up assertion macros Stephen Hemminger
2026-04-29 14:42 ` [PATCH 1/2] test: use inline helpers in buffer comparison macros Stephen Hemminger
2026-04-30 12:33 ` Marat Khalili
2026-04-29 14:42 ` [PATCH 2/2] test: parenthesize assertion macro parameters Stephen Hemminger
2026-04-30 11:53 ` Marat Khalili
2026-05-01 16:34 ` [PATCH v2 0/2] test: cleanup assertion macros Stephen Hemminger
2026-05-01 16:34 ` [PATCH v2 1/2] test: use inline helpers in buffer comparison macros Stephen Hemminger
2026-05-01 16:34 ` [PATCH v2 2/2] test: parenthesize assertion macro parameters Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429072610.1f87ad78@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=wpan3636@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox