From: Marat Khalili <marat.khalili@huawei.com>
To: Marat Khalili <marat.khalili@huawei.com>,
Weijun Pan <wpan3636@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Weijun Pan <wpan36@wisc.edu>
Subject: RE: [PATCH] test: parenthesize assertion macro parameters
Date: Fri, 24 Apr 2026 11:12:14 +0000 [thread overview]
Message-ID: <86b215390cc9483ca5915ab852e7d23c@huawei.com> (raw)
In-Reply-To: <254bea4a0dcf4161bbecc563dc65b0db@huawei.com>
> The patch is technically correct and would work, neither of my comments is a
> blocker (although last one might be a blocker from maintainer), but given that
> there are three of them maybe you would want to send a v2 to practice the
> process. Don't forget --in-reply-to when sending it.
P.S. Please also consider if this patch needs Fixes: and Cc: stable@dpdk.org headers and mention why in the cover letter if you think it doesn't.
next prev parent reply other threads:[~2026-04-24 11:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 16:48 [PATCH] test: parenthesize assertion macro parameters Weijun Pan
2026-04-24 9:48 ` Marat Khalili
2026-04-24 11:12 ` Marat Khalili [this message]
2026-04-27 17:17 ` [PATCH v2] " Weijun Pan
2026-04-29 12:31 ` Marat Khalili
2026-04-29 14:26 ` Stephen Hemminger
2026-04-29 14:42 ` [PATCH 0/2] test: clean up assertion macros Stephen Hemminger
2026-04-29 14:42 ` [PATCH 1/2] test: use inline helpers in buffer comparison macros Stephen Hemminger
2026-04-30 12:33 ` Marat Khalili
2026-04-29 14:42 ` [PATCH 2/2] test: parenthesize assertion macro parameters Stephen Hemminger
2026-04-30 11:53 ` Marat Khalili
2026-05-01 16:34 ` [PATCH v2 0/2] test: cleanup assertion macros Stephen Hemminger
2026-05-01 16:34 ` [PATCH v2 1/2] test: use inline helpers in buffer comparison macros Stephen Hemminger
2026-05-01 16:34 ` [PATCH v2 2/2] test: parenthesize assertion macro parameters Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86b215390cc9483ca5915ab852e7d23c@huawei.com \
--to=marat.khalili@huawei.com \
--cc=dev@dpdk.org \
--cc=wpan3636@gmail.com \
--cc=wpan36@wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox