From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v2 0/2] test: cleanup assertion macros
Date: Fri, 1 May 2026 09:34:44 -0700 [thread overview]
Message-ID: <20260501163533.2689152-1-stephen@networkplumber.org> (raw)
In-Reply-To: <20260429144632.164970-1-stephen@networkplumber.org>
Two patches addressing Bugzilla 1925, which reported missing
parentheses around macro parameters in the DPDK test assertion
macros.
The TEST_ASSERT_BUFFERS_ARE_EQUAL family in app/test/test.h turned
out to have additional issues beyond missing parens -- multiple
evaluation of arguments, no type checking, and a dropped
__VA_ARGS__ in the _OFFSET wrappers -- so patch 1 moves the
comparison logic into static inline helpers. The macros are now
thin wrappers around the printf / TEST_TRACE_FAILURE / return
TEST_FAILED boilerplate. Existing call sites need no changes.
Patch 2 is Weijun Pan's original rte_test.h paren fix carried
through unchanged.
v2 - incorporate review feedback
Stephen Hemminger (1):
test: use inline helpers in buffer comparison macros
Weijun Pan (1):
test: parenthesize assertion macro parameters
.mailmap | 1 +
app/test/test.h | 146 +++++++++++++++++++++++--------------
lib/eal/include/rte_test.h | 12 +--
3 files changed, 100 insertions(+), 59 deletions(-)
--
2.53.0
next prev parent reply other threads:[~2026-05-01 16:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 16:48 [PATCH] test: parenthesize assertion macro parameters Weijun Pan
2026-04-24 9:48 ` Marat Khalili
2026-04-24 11:12 ` Marat Khalili
2026-04-27 17:17 ` [PATCH v2] " Weijun Pan
2026-04-29 12:31 ` Marat Khalili
2026-04-29 14:26 ` Stephen Hemminger
2026-04-29 14:42 ` [PATCH 0/2] test: clean up assertion macros Stephen Hemminger
2026-04-29 14:42 ` [PATCH 1/2] test: use inline helpers in buffer comparison macros Stephen Hemminger
2026-04-30 12:33 ` Marat Khalili
2026-04-29 14:42 ` [PATCH 2/2] test: parenthesize assertion macro parameters Stephen Hemminger
2026-04-30 11:53 ` Marat Khalili
2026-05-01 16:34 ` Stephen Hemminger [this message]
2026-05-01 16:34 ` [PATCH v2 1/2] test: use inline helpers in buffer comparison macros Stephen Hemminger
2026-05-01 16:34 ` [PATCH v2 2/2] test: parenthesize assertion macro parameters Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260501163533.2689152-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox