From: Stephen Hemminger <stephen@networkplumber.org>
To: Denis Lyulin <lyulin.2003@mail.ru>
Cc: Ori Kam <orika@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Michael Baum <michaelba@nvidia.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
dev@dpdk.org, stable@dpdk.org, adrien.mazarguil@6wind.com
Subject: Re: [PATCH v2] ethdev: fix pointer check in GENEVE and RAW flow copy
Date: Tue, 19 May 2026 07:40:02 -0700 [thread overview]
Message-ID: <20260519074002.37890cf0@phoenix.local> (raw)
In-Reply-To: <20260519072335.16601-1-lyulin.2003@mail.ru>
On Tue, 19 May 2026 10:23:35 +0300
Denis Lyulin <lyulin.2003@mail.ru> wrote:
> When rte_flow_conv_item_spec() is called from rte_flow_conv_pattern(),
> the spec, last and mask pointers are checked separately. If the API
> is used incorrectly, the spec pointer may be NULL while last and mask
> may be valid pointers. Also call of rte_flow_conv() with
> RTE_FLOW_CONV_OP_ITEM_MASK and item->spec == NULL may lead to the
> same problem.
>
> In rte_flow_conv_item_spec() for GENVE_OPT and RAW item types the spec
> pointer is used even if the function is called to copy last or mask.
> It may cause a NULL pointer (spec) dereference.
>
> This commit adds extra check of item->spec and if it is NULL, does not
> copy further data relying on it
>
> Fixes: 841a0445442d ("ethdev: fix GENEVE option item conversion")
> Cc: michaelba@nvidia.com
> Cc: adrien.mazarguil@6wind.com
> Cc: stephen@networkplumber.org
> Cc: stable@dpdk.org
>
> Signed-off-by: Denis Lyulin <lyulin.2003@mail.ru>
> ---
Applied to next-net
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Denis Lyulin <lyulin.2003@mail.ru>
Cc: Ori Kam <orika@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Michael Baum <michaelba@nvidia.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
dev@dpdk.org, stable@dpdk.org, adrien.mazarguil@6wind.com
Subject: Re: [PATCH v2] ethdev: fix pointer check in GENEVE and RAW flow copy
Date: Tue, 19 May 2026 07:40:16 -0700 [thread overview]
Message-ID: <20260519074002.37890cf0@phoenix.local> (raw)
Message-ID: <20260519144016.iIxNz_Ggj9mBzmHX7PSokxQJy8NSGiGLscWBaqfF0Go@z> (raw)
In-Reply-To: <20260519072335.16601-1-lyulin.2003@mail.ru>
On Tue, 19 May 2026 10:23:35 +0300
Denis Lyulin <lyulin.2003@mail.ru> wrote:
> When rte_flow_conv_item_spec() is called from rte_flow_conv_pattern(),
> the spec, last and mask pointers are checked separately. If the API
> is used incorrectly, the spec pointer may be NULL while last and mask
> may be valid pointers. Also call of rte_flow_conv() with
> RTE_FLOW_CONV_OP_ITEM_MASK and item->spec == NULL may lead to the
> same problem.
>
> In rte_flow_conv_item_spec() for GENVE_OPT and RAW item types the spec
> pointer is used even if the function is called to copy last or mask.
> It may cause a NULL pointer (spec) dereference.
>
> This commit adds extra check of item->spec and if it is NULL, does not
> copy further data relying on it
>
> Fixes: 841a0445442d ("ethdev: fix GENEVE option item conversion")
> Cc: michaelba@nvidia.com
> Cc: adrien.mazarguil@6wind.com
> Cc: stephen@networkplumber.org
> Cc: stable@dpdk.org
>
> Signed-off-by: Denis Lyulin <lyulin.2003@mail.ru>
> ---
Applied to next-net
next prev parent reply other threads:[~2026-05-19 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 7:23 [PATCH v2] ethdev: fix pointer check in GENEVE and RAW flow copy Denis Lyulin
2026-05-19 14:40 ` Stephen Hemminger [this message]
2026-05-19 14:40 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519074002.37890cf0@phoenix.local \
--to=stephen@networkplumber.org \
--cc=adrien.mazarguil@6wind.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=lyulin.2003@mail.ru \
--cc=michaelba@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox