DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	stable@dpdk.org, Devendra Singh Rawat <dsinghrawat@marvell.com>,
	Alok Prasad <palok@marvell.com>, Rasesh Mody <rmody@marvell.com>,
	Igor Russkikh <irusskikh@marvell.com>
Subject: [PATCH 4/4] net/qede: remove unused app version variable
Date: Wed, 26 Aug 2026 16:43:04 -0700	[thread overview]
Message-ID: <20260826235933.194681-5-stephen@networkplumber.org> (raw)
In-Reply-To: <20260826235933.194681-1-stephen@networkplumber.org>

qed_dbg_set_app_ver() validates the caller's version and stores it.
But the variable s_app_ver is never used in DPDK driver.

clang 23 reports:

  qede_debug.c:820:12: warning: variable 's_app_ver' set but not used
        [-Wunused-but-set-global]

Remove the variable and the dead store.

Fixes: ec55c118792b ("net/qede: add infrastructure for debug data collection")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/qede/qede_debug.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/net/qede/qede_debug.c b/drivers/net/qede/qede_debug.c
index 1d3147b724..8afaa5c108 100644
--- a/drivers/net/qede/qede_debug.c
+++ b/drivers/net/qede/qede_debug.c
@@ -812,13 +812,6 @@ static struct split_type_defs s_split_type_defs[] = {
 	{"vf"}
 };
 
-/******************************** Variables *********************************/
-
-/**
- * The version of the calling app
- */
-static u32 s_app_ver;
-
 /**************************** Private Functions ******************************/
 
 /* Reads and returns a single dword from the specified unaligned buffer */
@@ -4869,8 +4862,6 @@ enum dbg_status qed_dbg_set_app_ver(u32 ver)
 	if (ver < TOOLS_VERSION)
 		return DBG_STATUS_UNSUPPORTED_APP_VERSION;
 
-	s_app_ver = ver;
-
 	return DBG_STATUS_OK;
 }
 
-- 
2.53.0


  parent reply	other threads:[~2026-08-27  0:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 23:43 [PATCH 0/4] fix unused-but-set-global warnings Stephen Hemminger
2026-08-26 23:43 ` [PATCH 1/4] common/dpaax: fix unused variable warning in non-debug build Stephen Hemminger
2026-08-27  9:07   ` David Marchand
2026-08-27 14:57     ` Stephen Hemminger
2026-08-27 15:55       ` Hemant Agrawal
2026-08-26 23:43 ` [PATCH 2/4] bus/dpaa: remove unused qman_clk variable Stephen Hemminger
2026-08-27 15:57   ` Hemant Agrawal
2026-08-26 23:43 ` [PATCH 3/4] common/zsda: remove unused device counter Stephen Hemminger
2026-08-26 23:43 ` Stephen Hemminger [this message]
2026-08-27  9:08   ` [PATCH 4/4] net/qede: remove unused app version variable David Marchand
2026-08-27 14:59     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260826235933.194681-5-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=dsinghrawat@marvell.com \
    --cc=irusskikh@marvell.com \
    --cc=palok@marvell.com \
    --cc=rmody@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox