From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>
Subject: Re: [PATCH 1/4] common/dpaax: fix unused variable warning in non-debug build
Date: Thu, 27 Aug 2026 07:57:21 -0700 [thread overview]
Message-ID: <20260827075721.1344582e@phoenix.local> (raw)
In-Reply-To: <CAJFAV8x62b_zeyF5P-X4KSMxaD4Sd=XanED-7PitDztxtnUFFw@mail.gmail.com>
On Thu, 27 Aug 2026 11:07:50 +0200
David Marchand <david.marchand@redhat.com> wrote:
> On Thu, 27 Aug 2026 at 02:00, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > Fix compiler warning on clang-23.
> >
> > dpaa_of.c:14:12: warning: variable 'alive' set but not used
> > [-Wunused-but-set-global]
> >
> > The 'alive' flag is only read by DPAAX_HWWARN, which expands to an empty
> > statement and discards its condition unless RTE_LIBRTE_DPAAX_DEBUG is
> > defined. Make the empty expansion consume its argument so the condition
> > is still checked in a non-debug build.
> >
> > Fixes: 8c83f28cc8a4 ("common/dpaax: move OF library from DPAA bus")
>
> Not that important, the issue probably predates this commit.
> And looking at this change, it seems DPAA_BUS_HWWARN is dead code since then.
That is when the device-tree warning was added.
The history scan looks right.
It seems like it should either be removed as irrelevant or made into
a regular warning. But that is up to Hemant and Sachin to decide;
I just want clean builds for now.
next prev parent reply other threads:[~2026-08-27 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 23:43 [PATCH 0/4] fix unused-but-set-global warnings Stephen Hemminger
2026-08-26 23:43 ` [PATCH 1/4] common/dpaax: fix unused variable warning in non-debug build Stephen Hemminger
2026-08-27 9:07 ` David Marchand
2026-08-27 14:57 ` Stephen Hemminger [this message]
2026-08-27 15:55 ` Hemant Agrawal
2026-08-26 23:43 ` [PATCH 2/4] bus/dpaa: remove unused qman_clk variable Stephen Hemminger
2026-08-27 15:57 ` Hemant Agrawal
2026-08-26 23:43 ` [PATCH 3/4] common/zsda: remove unused device counter Stephen Hemminger
2026-08-26 23:43 ` [PATCH 4/4] net/qede: remove unused app version variable Stephen Hemminger
2026-08-27 9:08 ` David Marchand
2026-08-27 14:59 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827075721.1344582e@phoenix.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox