Re: [PATCH 1/4] common/dpaax: fix unused variable warning in non-debug build

[Hemant Agrawal <hemant.agrawal@oss.nxp.com>]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]


On 27-08-2026 20:27, Stephen Hemminger wrote:
> On Thu, 27 Aug 2026 11:07:50 +0200
> David Marchand<david.marchand@redhat.com> wrote:
>
>> On Thu, 27 Aug 2026 at 02:00, Stephen Hemminger
>> <stephen@networkplumber.org> wrote:
>>> Fix compiler warning on clang-23.
>>>
>>>    dpaa_of.c:14:12: warning: variable 'alive' set but not used
>>>          [-Wunused-but-set-global]
>>>
>>> The 'alive' flag is only read by DPAAX_HWWARN, which expands to an empty
>>> statement and discards its condition unless RTE_LIBRTE_DPAAX_DEBUG is
>>> defined. Make the empty expansion consume its argument so the condition
>>> is still checked in a non-debug build.
>>>
>>> Fixes: 8c83f28cc8a4 ("common/dpaax: move OF library from DPAA bus")
>> Not that important, the issue probably predates this commit.
>> And looking at this change, it seems DPAA_BUS_HWWARN is dead code since then.
> That is when the device-tree warning was added.
> The history scan looks right.
>
> It seems like it should either be removed as irrelevant or made into
> a regular warning. But that is up to Hemant and Sachin to decide;
> I just want clean builds for now.We need to remove this define.
We will plan to remove this definition in future.

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

[-- Attachment #2: Type: text/html, Size: 2334 bytes --]