* [PATCH] ci: fix dependency on cmdline
@ 2026-10-15 16:01 David Marchand
2026-10-15 16:18 ` David Marchand
2026-10-15 16:23 ` Robin Jarry
0 siblings, 2 replies; 6+ messages in thread
From: David Marchand @ 2026-10-15 16:01 UTC (permalink / raw)
To: dev; +Cc: thomas, Aaron Conole, Robin Jarry, Bruce Richardson
The unit tests, testpmd and some examples depend on the cmdline library.
Without it, the "mini" target in GHA ends up as a build failure.
Fixes: 6de2c9c791b8 ("build: make cmdline optional")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
.ci/linux-build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 4f266940e9..2c7386d320 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -120,7 +120,7 @@ else
fi
if [ "$MINI" = "true" ]; then
OPTS="$OPTS -Denable_drivers=net/null"
- OPTS="$OPTS -Ddisable_libs=*"
+ OPTS="$OPTS -Denable_libs=cmdline"
if [ "$DEF_LIB" = "static" ]; then
OPTS="$OPTS -Dexamples=l2fwd"
fi
--
2.54.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ci: fix dependency on cmdline
2026-10-15 16:01 [PATCH] ci: fix dependency on cmdline David Marchand
@ 2026-10-15 16:18 ` David Marchand
2026-10-15 16:23 ` Robin Jarry
1 sibling, 0 replies; 6+ messages in thread
From: David Marchand @ 2026-10-15 16:18 UTC (permalink / raw)
To: David Marchand; +Cc: dev, thomas, Aaron Conole, Robin Jarry, Bruce Richardson
On Thu, 15 Oct 2026 at 18:02, David Marchand <david.marchand@redhat.com> wrote:
>
> The unit tests, testpmd and some examples depend on the cmdline library.
> Without it, the "mini" target in GHA ends up as a build failure.
>
> Fixes: 6de2c9c791b8 ("build: make cmdline optional")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Applied quickly, to avoid red flags in GHA.
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ci: fix dependency on cmdline
2026-10-15 16:01 [PATCH] ci: fix dependency on cmdline David Marchand
2026-10-15 16:18 ` David Marchand
@ 2026-10-15 16:23 ` Robin Jarry
2026-10-15 16:25 ` David Marchand
1 sibling, 1 reply; 6+ messages in thread
From: Robin Jarry @ 2026-10-15 16:23 UTC (permalink / raw)
To: David Marchand, dev; +Cc: thomas, Aaron Conole, Bruce Richardson
David Marchand, Oct 15, 2026 at 18:01:
> The unit tests, testpmd and some examples depend on the cmdline library.
> Without it, the "mini" target in GHA ends up as a build failure.
>
> Fixes: 6de2c9c791b8 ("build: make cmdline optional")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> .ci/linux-build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> index 4f266940e9..2c7386d320 100755
> --- a/.ci/linux-build.sh
> +++ b/.ci/linux-build.sh
> @@ -120,7 +120,7 @@ else
> fi
> if [ "$MINI" = "true" ]; then
> OPTS="$OPTS -Denable_drivers=net/null"
> - OPTS="$OPTS -Ddisable_libs=*"
> + OPTS="$OPTS -Denable_libs=cmdline"
> if [ "$DEF_LIB" = "static" ]; then
> OPTS="$OPTS -Dexamples=l2fwd"
Why aren't the per-target dependencies honored?
--
Robin
# At participating locations only.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ci: fix dependency on cmdline
2026-10-15 16:23 ` Robin Jarry
@ 2026-10-15 16:25 ` David Marchand
2026-10-15 16:26 ` Robin Jarry
0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2026-10-15 16:25 UTC (permalink / raw)
To: Robin Jarry; +Cc: dev, thomas, Aaron Conole, Bruce Richardson
On Thu, 15 Oct 2026 at 18:23, Robin Jarry <rjarry@redhat.com> wrote:
>
> David Marchand, Oct 15, 2026 at 18:01:
> > The unit tests, testpmd and some examples depend on the cmdline library.
> > Without it, the "mini" target in GHA ends up as a build failure.
> >
> > Fixes: 6de2c9c791b8 ("build: make cmdline optional")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > .ci/linux-build.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> > index 4f266940e9..2c7386d320 100755
> > --- a/.ci/linux-build.sh
> > +++ b/.ci/linux-build.sh
> > @@ -120,7 +120,7 @@ else
> > fi
> > if [ "$MINI" = "true" ]; then
> > OPTS="$OPTS -Denable_drivers=net/null"
> > - OPTS="$OPTS -Ddisable_libs=*"
> > + OPTS="$OPTS -Denable_libs=cmdline"
> > if [ "$DEF_LIB" = "static" ]; then
> > OPTS="$OPTS -Dexamples=l2fwd"
>
> Why aren't the per-target dependencies honored?
Examples have hardcoded dependencies see examples/meson.build.
Since the mini target explicitly requests l2fwd, this triggers an error.
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ci: fix dependency on cmdline
2026-10-15 16:25 ` David Marchand
@ 2026-10-15 16:26 ` Robin Jarry
2026-10-15 16:31 ` David Marchand
0 siblings, 1 reply; 6+ messages in thread
From: Robin Jarry @ 2026-10-15 16:26 UTC (permalink / raw)
To: David Marchand; +Cc: dev, thomas, Aaron Conole, Bruce Richardson
David Marchand, Oct 15, 2026 at 18:25:
> Examples have hardcoded dependencies see examples/meson.build.
> Since the mini target explicitly requests l2fwd, this triggers an error.
Ah, so we would need to add the cmdline dependency per-example?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ci: fix dependency on cmdline
2026-10-15 16:26 ` Robin Jarry
@ 2026-10-15 16:31 ` David Marchand
0 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2026-10-15 16:31 UTC (permalink / raw)
To: Robin Jarry; +Cc: dev, thomas, Aaron Conole, Bruce Richardson
On Thu, 15 Oct 2026 at 18:26, Robin Jarry <rjarry@redhat.com> wrote:
>
> David Marchand, Oct 15, 2026 at 18:25:
> > Examples have hardcoded dependencies see examples/meson.build.
> > Since the mini target explicitly requests l2fwd, this triggers an error.
>
> Ah, so we would need to add the cmdline dependency per-example?
Dependencies should probably be re-evaluated.
You can send patches but too late for rc1 now.
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-10-15 16:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-15 16:01 [PATCH] ci: fix dependency on cmdline David Marchand
2026-10-15 16:18 ` David Marchand
2026-10-15 16:23 ` Robin Jarry
2026-10-15 16:25 ` David Marchand
2026-10-15 16:26 ` Robin Jarry
2026-10-15 16:31 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox