[DPDK/ethdev Bug 2042] net/intel/idpf and net/intel/cpfl: four byte store into a bool

[DPDK/ethdev Bug 2042] net/intel/idpf and net/intel/cpfl: four byte store into a bool

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=2042

            Bug ID: 2042
           Summary: net/intel/idpf and net/intel/cpfl: four byte store
                    into a bool
           Product: DPDK
           Version: 26.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: stephen@networkplumber.org
  Target Milestone: ---

drivers/net/intel/idpf/idpf_ethdev.c:1248
drivers/net/intel/cpfl/cpfl_ethdev.c (same handler, copied)

parse_bool() stores an int:

        int *i = args;
        ...
        *i = num;

Both callers in each driver pass the address of a bool:

        drivers/net/intel/idpf/idpf_common_device.h:104
                bool is_tx_singleq;
                bool is_rx_singleq;

so "tx_single=1" or "rx_single=1" writes four bytes into a one byte field.

Fixes: 549343c25db8 ("net/idpf: support device initialization")
Fixes: 2d823ecd671c ("net/cpfl: support device initialization")

-- 
You are receiving this mail because:
You are the assignee for the bug.