Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
* [Drbd-dev] [PATCH] block/drbd: remove unused w_start_resync declaration
@ 2022-09-11  9:26 Gaosheng Cui
  2022-09-12  7:36 ` Christoph Böhmwalder
  2022-09-12  7:48 ` Jens Axboe
  0 siblings, 2 replies; 4+ messages in thread
From: Gaosheng Cui @ 2022-09-11  9:26 UTC (permalink / raw)
  To: philipp.reisner, lars.ellenberg, christoph.boehmwalder, axboe,
	cuigaosheng1
  Cc: drbd-dev

w_start_resync has been removed since
commit ac0acb9e39ac ("drbd: use drbd_device_post_work()
in more places"), so remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/block/drbd/drbd_int.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
index f15f2f041596..4d661282ff41 100644
--- a/drivers/block/drbd/drbd_int.h
+++ b/drivers/block/drbd/drbd_int.h
@@ -1529,7 +1529,6 @@ extern int w_send_read_req(struct drbd_work *, int);
 extern int w_e_reissue(struct drbd_work *, int);
 extern int w_restart_disk_io(struct drbd_work *, int);
 extern int w_send_out_of_sync(struct drbd_work *, int);
-extern int w_start_resync(struct drbd_work *, int);
 
 extern void resync_timer_fn(struct timer_list *t);
 extern void start_resync_timer_fn(struct timer_list *t);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Drbd-dev] [PATCH] block/drbd: remove unused w_start_resync declaration
  2022-09-11  9:26 [Drbd-dev] [PATCH] block/drbd: remove unused w_start_resync declaration Gaosheng Cui
@ 2022-09-12  7:36 ` Christoph Böhmwalder
  2022-09-12  7:48 ` Jens Axboe
  1 sibling, 0 replies; 4+ messages in thread
From: Christoph Böhmwalder @ 2022-09-12  7:36 UTC (permalink / raw)
  To: Gaosheng Cui; +Cc: axboe, lars.ellenberg, philipp.reisner, drbd-dev

Am 11.09.22 um 11:26 schrieb Gaosheng Cui:
> w_start_resync has been removed since
> commit ac0acb9e39ac ("drbd: use drbd_device_post_work()
> in more places"), so remove it.
> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  drivers/block/drbd/drbd_int.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
> index f15f2f041596..4d661282ff41 100644
> --- a/drivers/block/drbd/drbd_int.h
> +++ b/drivers/block/drbd/drbd_int.h
> @@ -1529,7 +1529,6 @@ extern int w_send_read_req(struct drbd_work *, int);
>  extern int w_e_reissue(struct drbd_work *, int);
>  extern int w_restart_disk_io(struct drbd_work *, int);
>  extern int w_send_out_of_sync(struct drbd_work *, int);
> -extern int w_start_resync(struct drbd_work *, int);
>  
>  extern void resync_timer_fn(struct timer_list *t);
>  extern void start_resync_timer_fn(struct timer_list *t);

Thanks for the patch, looks good to me.

Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>

-- 
Christoph Böhmwalder
LINBIT | Keeping the Digital World Running
DRBD HA —  Disaster Recovery — Software defined Storage

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Drbd-dev] [PATCH] block/drbd: remove unused w_start_resync declaration
  2022-09-11  9:26 [Drbd-dev] [PATCH] block/drbd: remove unused w_start_resync declaration Gaosheng Cui
  2022-09-12  7:36 ` Christoph Böhmwalder
@ 2022-09-12  7:48 ` Jens Axboe
  2022-09-12  7:59   ` cuigaosheng
  1 sibling, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2022-09-12  7:48 UTC (permalink / raw)
  To: Gaosheng Cui, philipp.reisner, lars.ellenberg,
	christoph.boehmwalder
  Cc: drbd-dev

On 9/11/22 3:26 AM, Gaosheng Cui wrote:
> w_start_resync has been removed since
> commit ac0acb9e39ac ("drbd: use drbd_device_post_work()
> in more places"), so remove it.

Applied, but please also cc linux-block or other lists that manage
kernel patches in the future. You can't use lore/b4/lei with patches
that are only on some driver private list.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Drbd-dev] [PATCH] block/drbd: remove unused w_start_resync declaration
  2022-09-12  7:48 ` Jens Axboe
@ 2022-09-12  7:59   ` cuigaosheng
  0 siblings, 0 replies; 4+ messages in thread
From: cuigaosheng @ 2022-09-12  7:59 UTC (permalink / raw)
  To: Jens Axboe, philipp.reisner, lars.ellenberg,
	christoph.boehmwalder; +Cc: drbd-dev


> Applied, but please also cc linux-block or other lists that manage
> kernel patches in the future. You can't use lore/b4/lei with patches
> that are only on some driver private list.

Thanks,I will cc other list that manage kernel patches in the future.

在 2022/9/12 15:48, Jens Axboe 写道:
> On 9/11/22 3:26 AM, Gaosheng Cui wrote:
>> w_start_resync has been removed since
>> commit ac0acb9e39ac ("drbd: use drbd_device_post_work()
>> in more places"), so remove it.
> Applied, but please also cc linux-block or other lists that manage
> kernel patches in the future. You can't use lore/b4/lei with patches
> that are only on some driver private list.
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-09-12  7:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-11  9:26 [Drbd-dev] [PATCH] block/drbd: remove unused w_start_resync declaration Gaosheng Cui
2022-09-12  7:36 ` Christoph Böhmwalder
2022-09-12  7:48 ` Jens Axboe
2022-09-12  7:59   ` cuigaosheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox