Re: [Drbd-dev] [PATCH] drbd: Use seq_putc() once more in drbd_syncer_progress()

Re: [Drbd-dev] [PATCH] drbd: Use seq_putc() once more in drbd_syncer_progress()

[Roland Kammerer]

On Mon, May 01, 2017 at 08:18:20PM +0200, elfring@users.sourceforge.net wrote:
> From: SF Markus Elfring <elfring@users.sourceforge.net>
> Subject: [PATCH] drbd: Use seq_putc() once more in drbd_syncer_progress()
> Date: Mon, 1 May 2017 20:12:58 +0200
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
>  Thunderbird/52.0.1
> 
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 1 May 2017 20:05:08 +0200
> 
> A single dot should be put into a sequence.
> Thus use the corresponding function "seq_putc".
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/block/drbd/drbd_proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/drbd/drbd_proc.c b/drivers/block/drbd/drbd_proc.c
> index 8378142f7a55..fc0f627567fd 100644
> --- a/drivers/block/drbd/drbd_proc.c
> +++ b/drivers/block/drbd/drbd_proc.c
> @@ -127,7 +127,7 @@ static void drbd_syncer_progress(struct drbd_device *device, struct seq_file *se
>  		seq_putc(seq, '=');
>  	seq_putc(seq, '>');
>  	for (i = 0; i < y; i++)
> -		seq_printf(seq, ".");
> +		seq_putc(seq, '.');
>  	seq_puts(seq, "] ");
>  
>  	if (state.conn == C_VERIFY_S || state.conn == C_VERIFY_T)

Thanks, applied internally, will be upstream eventually.

Regards, rck