* Re: [PATCH] drbd: remove unused drbd_nl_mcgrps[] array
[not found] <20260519203057.1340528-1-arnd@kernel.org>
@ 2026-05-19 20:51 ` Christoph Böhmwalder
2026-09-24 13:20 ` Christoph Böhmwalder
1 sibling, 0 replies; 2+ messages in thread
From: Christoph Böhmwalder @ 2026-05-19 20:51 UTC (permalink / raw)
To: Arnd Bergmann, Philipp Reisner, Lars Ellenberg, Jens Axboe,
Jakub Kicinski
Cc: Arnd Bergmann, drbd-dev, linux-block, linux-kernel, drbd-dev
On 5/19/26 22:30, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> After the rework, two files have a copy of drbd_nl_mcgrps[], but one
> of them has no references:
>
> drivers/block/drbd/drbd_nl_gen.c:641:42: error: 'drbd_nl_mcgrps' defined but not used [-Werror=unused-const-variable=]
> 641 | static const struct genl_multicast_group drbd_nl_mcgrps[] = {
> | ^~~~~~~~~~~~~~
>
> At the default warning level, -Wunused-const-variables is turned off,
> so this has gone unnoticed.
>
> Remove the extra variable.
>
> Fixes: 8098eeb693c4 ("drbd: replace genl_magic with explicit netlink serialization")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Oops, looks like a copy/paste error on my side.
Thanks for noticing and fixing.
Reviewed-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drbd: remove unused drbd_nl_mcgrps[] array
[not found] <20260519203057.1340528-1-arnd@kernel.org>
2026-05-19 20:51 ` [PATCH] drbd: remove unused drbd_nl_mcgrps[] array Christoph Böhmwalder
@ 2026-09-24 13:20 ` Christoph Böhmwalder
1 sibling, 0 replies; 2+ messages in thread
From: Christoph Böhmwalder @ 2026-09-24 13:20 UTC (permalink / raw)
To: Jens Axboe
Cc: Arnd Bergmann, linux-block, linux-kernel, Lars Ellenberg,
Philipp Reisner, drbd-dev
On 5/19/26 22:30, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> After the rework, two files have a copy of drbd_nl_mcgrps[], but one
> of them has no references:
>
> drivers/block/drbd/drbd_nl_gen.c:641:42: error: 'drbd_nl_mcgrps' defined but not used [-Werror=unused-const-variable=]
> 641 | static const struct genl_multicast_group drbd_nl_mcgrps[] = {
> | ^~~~~~~~~~~~~~
>
> At the default warning level, -Wunused-const-variables is turned off,
> so this has gone unnoticed.
>
> Remove the extra variable.
>
> Fixes: 8098eeb693c4 ("drbd: replace genl_magic with explicit netlink serialization")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/block/drbd/drbd_nl_gen.c | 4 ----
> 1 file changed, 4 deletions(-)
@Jens ping, seems like this was never applied? I think it should also
apply to the current tree.
Thanks,
Christoph
^ permalink raw reply [flat|nested] 2+ messages in thread