Re: [PATCH] drm/mgag200: Cleanup: Remove pointless call to drm_fb_get_bpp_depth

From: Paul Menzel <paulepanter@users.sourceforge.net>
To: Christopher Harvey <charvey@matrox.com>
Cc: Julia Lemire <jlemire@matrox.com>,
	Mathieu Larouche <mathieu.larouche@matrox.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/mgag200: Cleanup: Remove pointless call to drm_fb_get_bpp_depth
Date: Wed, 27 Feb 2013 00:22:02 +0100	[thread overview]
Message-ID: <1361920922.6140.28.camel@mattotaupa> (raw)
In-Reply-To: <20130226155358.GA18614@harvey-pc.matrox.com>

[-- Attachment #1.1: Type: text/plain, Size: 1300 bytes --]

Dear Christopher,

thank you for your patches. Not sure if you should CC some maintainer
(or if you did already).

Am Dienstag, den 26.02.2013, 10:53 -0500 schrieb Christopher Harvey:

1. I guess you can remove Cleanup from the commit summary.
2. Why is it »pointless«? I guess a compiler warning that bpp is unused?
Please paste it into the commit message then. As otherwise this cannot
be judged from just looking at the diff below.

> Signed-off-by: Christopher Harvey <charvey@matrox.com>
> ---
>  drivers/gpu/drm/mgag200/mgag200_fb.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200/mgag200_fb.c
> index 2f48648..d46bd2c 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_fb.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_fb.c
> @@ -104,12 +104,9 @@ static int mgag200fb_create_object(struct mga_fbdev *afbdev,
>  				   struct drm_gem_object **gobj_p)
>  {
>  	struct drm_device *dev = afbdev->helper.dev;
> -	u32 bpp, depth;
>  	u32 size;
>  	struct drm_gem_object *gobj;
> -
>  	int ret = 0;
> -	drm_fb_get_bpp_depth(mode_cmd->pixel_format, &depth, &bpp);
>  
>  	size = mode_cmd->pitches[0] * mode_cmd->height;
>  	ret = mgag200_gem_create(dev, size, true, &gobj);

Thanks,

Paul

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel