From: Paul Menzel <paulepanter@users.sourceforge.net>
To: Christopher Harvey <charvey@matrox.com>
Cc: Julia Lemire <jlemire@matrox.com>,
Mathieu Larouche <mathieu.larouche@matrox.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/mgag200: Cleanup: Remove extra variable assigns
Date: Wed, 27 Feb 2013 00:28:57 +0100 [thread overview]
Message-ID: <1361921337.6140.31.camel@mattotaupa> (raw)
In-Reply-To: <20130226155510.GA18647@harvey-pc.matrox.com>
[-- Attachment #1.1: Type: text/plain, Size: 1135 bytes --]
Am Dienstag, den 26.02.2013, 10:55 -0500 schrieb Christopher Harvey:
*assignments
> These two variables are set again immediately in 'mgag200_modeset_init'
The compiler would optimize this anyway I guess. Though now it can warn
us, if the code should ever change and these variable are not set
anymore in all cases.
> Signed-off-by: Christopher Harvey <charvey@matrox.com>
> ---
> drivers/gpu/drm/mgag200/mgag200_main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c
> index 70dd3c5..aad280a 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_main.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_main.c
> @@ -240,8 +240,6 @@ int mgag200_driver_load(struct drm_device *dev, unsigned long flags)
>
> drm_mode_config_init(dev);
> dev->mode_config.funcs = (void *)&mga_mode_funcs;
> - dev->mode_config.min_width = 0;
> - dev->mode_config.min_height = 0;
> dev->mode_config.preferred_depth = 24;
> dev->mode_config.prefer_shadow = 1;
Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
Thanks,
Paul
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-02-26 23:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 15:52 [PATCH] mgag200: some cleanup and a fix for corrupted output Christopher Harvey
2013-02-26 15:53 ` [PATCH] drm/mgag200: Cleanup: Remove pointless call to drm_fb_get_bpp_depth Christopher Harvey
2013-02-26 23:22 ` Paul Menzel
2013-02-26 15:54 ` [PATCH] drm/mgag200: Cleanup: 'fbdev_list' in 'struct mga_fbdev' is not used Christopher Harvey
2013-02-26 15:54 ` [PATCH] drm/mgag200: Cleanup: Pass driver specific mga_device in driver functions Christopher Harvey
2013-02-26 23:25 ` Paul Menzel
2013-02-26 15:55 ` [PATCH] drm/mgag200: Cleanup: Remove extra variable assigns Christopher Harvey
2013-02-26 23:28 ` Paul Menzel [this message]
2013-02-26 15:55 ` [PATCH] drm/mgag200: Reject modes that are too big for VRAM Christopher Harvey
2013-02-26 23:34 ` Paul Menzel
2013-03-07 0:38 ` Dave Airlie
2013-03-06 18:51 ` [PATCH] mgag200: some cleanup and a fix for corrupted output Christopher Harvey
2013-03-06 21:02 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361921337.6140.31.camel@mattotaupa \
--to=paulepanter@users.sourceforge.net \
--cc=charvey@matrox.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jlemire@matrox.com \
--cc=mathieu.larouche@matrox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox