* [PATCH 1/3] drm/imx: check the value returned by regulator_set_voltage()
@ 2016-07-09 21:57 Fabio Estevam
2016-07-09 21:57 ` [PATCH 2/3] drm/imx: fix the error message Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2016-07-09 21:57 UTC (permalink / raw)
To: p.zabel; +Cc: Fabio Estevam, dri-devel
From: Fabio Estevam <fabio.estevam@nxp.com>
regulator_set_voltage() may fail, so we better check its return value
and propagate it in the case of error.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/gpu/drm/imx/imx-tve.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
index baf7881..c93301c 100644
--- a/drivers/gpu/drm/imx/imx-tve.c
+++ b/drivers/gpu/drm/imx/imx-tve.c
@@ -633,7 +633,9 @@ static int imx_tve_bind(struct device *dev, struct device *master, void *data)
tve->dac_reg = devm_regulator_get(dev, "dac");
if (!IS_ERR(tve->dac_reg)) {
- regulator_set_voltage(tve->dac_reg, 2750000, 2750000);
+ ret = regulator_set_voltage(tve->dac_reg, 2750000, 2750000);
+ if (ret)
+ return ret;
ret = regulator_enable(tve->dac_reg);
if (ret)
return ret;
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] drm/imx: fix the error message
2016-07-09 21:57 [PATCH 1/3] drm/imx: check the value returned by regulator_set_voltage() Fabio Estevam
@ 2016-07-09 21:57 ` Fabio Estevam
2016-07-09 21:57 ` [PATCH 3/3] drm/imx: remove unneeded 'or' operation Fabio Estevam
2016-07-11 10:26 ` [PATCH 1/3] drm/imx: check the value returned by regulator_set_voltage() Philipp Zabel
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2016-07-09 21:57 UTC (permalink / raw)
To: p.zabel; +Cc: Fabio Estevam, dri-devel
From: Fabio Estevam <fabio.estevam@nxp.com>
The error message should say "hsync" instead of "vsync" as
we have just checked the "fsl,hsync-pin" property.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/gpu/drm/imx/imx-tve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
index c93301c..a52939c 100644
--- a/drivers/gpu/drm/imx/imx-tve.c
+++ b/drivers/gpu/drm/imx/imx-tve.c
@@ -590,7 +590,7 @@ static int imx_tve_bind(struct device *dev, struct device *master, void *data)
&tve->hsync_pin);
if (ret < 0) {
- dev_err(dev, "failed to get vsync pin\n");
+ dev_err(dev, "failed to get hsync pin\n");
return ret;
}
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] drm/imx: remove unneeded 'or' operation
2016-07-09 21:57 [PATCH 1/3] drm/imx: check the value returned by regulator_set_voltage() Fabio Estevam
2016-07-09 21:57 ` [PATCH 2/3] drm/imx: fix the error message Fabio Estevam
@ 2016-07-09 21:57 ` Fabio Estevam
2016-07-11 10:26 ` [PATCH 1/3] drm/imx: check the value returned by regulator_set_voltage() Philipp Zabel
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2016-07-09 21:57 UTC (permalink / raw)
To: p.zabel; +Cc: Fabio Estevam, dri-devel
From: Fabio Estevam <fabio.estevam@nxp.com>
There is no need for doing an extra 'or' operation when reading
the return value from of_property_read_u32().
Just do a simple read instead.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/gpu/drm/imx/imx-tve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
index a52939c..2cf0631 100644
--- a/drivers/gpu/drm/imx/imx-tve.c
+++ b/drivers/gpu/drm/imx/imx-tve.c
@@ -594,7 +594,7 @@ static int imx_tve_bind(struct device *dev, struct device *master, void *data)
return ret;
}
- ret |= of_property_read_u32(np, "fsl,vsync-pin",
+ ret = of_property_read_u32(np, "fsl,vsync-pin",
&tve->vsync_pin);
if (ret < 0) {
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] drm/imx: check the value returned by regulator_set_voltage()
2016-07-09 21:57 [PATCH 1/3] drm/imx: check the value returned by regulator_set_voltage() Fabio Estevam
2016-07-09 21:57 ` [PATCH 2/3] drm/imx: fix the error message Fabio Estevam
2016-07-09 21:57 ` [PATCH 3/3] drm/imx: remove unneeded 'or' operation Fabio Estevam
@ 2016-07-11 10:26 ` Philipp Zabel
2 siblings, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2016-07-11 10:26 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, dri-devel
Am Samstag, den 09.07.2016, 18:57 -0300 schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> regulator_set_voltage() may fail, so we better check its return value
> and propagate it in the case of error.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied all three, thank you.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-11 10:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-09 21:57 [PATCH 1/3] drm/imx: check the value returned by regulator_set_voltage() Fabio Estevam
2016-07-09 21:57 ` [PATCH 2/3] drm/imx: fix the error message Fabio Estevam
2016-07-09 21:57 ` [PATCH 3/3] drm/imx: remove unneeded 'or' operation Fabio Estevam
2016-07-11 10:26 ` [PATCH 1/3] drm/imx: check the value returned by regulator_set_voltage() Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox