dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 08/23] drm/via: use drm_mm instead of drm_sman
Date: Thu, 27 Oct 2011 23:00:09 +0200	[thread overview]
Message-ID: <20111027210009.GA4876@phenom.ffwll.local> (raw)
In-Reply-To: <1319713670-7475-9-git-send-email-daniel.vetter@ffwll.ch>

On Thu, Oct 27, 2011 at 01:07:35PM +0200, Daniel Vetter wrote:
> Now that we are again in proper control of owner_list, we need to
> properly list_del it on free.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Chris Wilson rightly complained that this doesn't explain the list_del
magic going on. New commit msg reads:

    To make the transition in a piece-wise and bisectable way possible,
    I've hijacked the ->owner_list from drm_sman. While transitioning, the
    list_add was done by the driver, while the list_del was still done by
    the dying sman code.
    
    Now that we are in full control of ->owner_list, do the list_del
    ourselves.

He also noted the superflous additions of INIT_LIST_HEAD and the stale
comment about spinlock locking in the idr allocation (protected by
dev->struct_mutex) that I've copied over. All fixed up and pushed out for
the moment to my fdo repo:

http://cgit.freedesktop.org/~danvet/drm/log/?h=kill-with-fire

Cheers, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

  reply	other threads:[~2011-10-27 20:59 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-27 11:07 [PATCH 00/23] kill drm cruft with fire Daniel Vetter
2011-10-27 11:07 ` [PATCH 01/23] drm/sis: track obj->drm_fd relations in the driver Daniel Vetter
2011-10-27 11:07 ` [PATCH 02/23] drm/via: " Daniel Vetter
2011-12-07 16:21   ` James Simmons
2011-10-27 11:07 ` [PATCH 03/23] drm/sman: kill owner tracking interface functions Daniel Vetter
2011-12-07 16:21   ` James Simmons
2011-10-27 11:07 ` [PATCH 04/23] drm/sman: rip out owner tracking Daniel Vetter
2011-12-07 16:22   ` James Simmons
2011-10-27 11:07 ` [PATCH 05/23] drm/via: track user->memblock mapping with idr Daniel Vetter
2011-12-07 16:22   ` James Simmons
2011-10-27 11:07 ` [PATCH 06/23] drm/sis: " Daniel Vetter
2011-12-07 16:22   ` James Simmons
2011-10-27 11:07 ` [PATCH 07/23] drm/sman: kill user_hash_tab Daniel Vetter
2011-12-07 16:22   ` James Simmons
2011-10-27 11:07 ` [PATCH 08/23] drm/via: use drm_mm instead of drm_sman Daniel Vetter
2011-10-27 21:00   ` Daniel Vetter [this message]
2011-12-07 16:28     ` James Simmons
2011-12-12 22:51       ` Daniel Vetter
2011-12-07 16:23   ` James Simmons
2011-10-27 11:07 ` [PATCH 09/23] drm/sis: " Daniel Vetter
2011-10-28 22:47   ` Tormod Volden
2011-10-28 23:05     ` [PATCH] drm/sis: Fix building with CONFIG_FB_SIS/CONFIG_FB_SIS_MODULE Tormod Volden
2011-10-29  0:25     ` [PATCH 09/23] drm/sis: use drm_mm instead of drm_sman Daniel Vetter
2011-10-29  6:52       ` Tormod Volden
2011-10-29  9:44         ` Daniel Vetter
2011-12-07 16:23   ` James Simmons
2011-10-27 11:07 ` [PATCH 10/23] drm: kill drm_sman Daniel Vetter
2011-12-07 16:24   ` James Simmons
2011-10-27 11:07 ` [PATCH 11/23] drm/via: clean up reclaim_buffers Daniel Vetter
2011-12-08  0:26   ` James Simmons
2011-10-27 11:07 ` [PATCH 12/23] drm/sis: " Daniel Vetter
2011-10-27 11:07 ` [PATCH 13/23] drm: kill reclaim_buffers_idlelocked functions Daniel Vetter
2011-10-27 11:07 ` [PATCH 14/23] drm/i810: cleanup reclaim_buffers Daniel Vetter
2011-10-27 11:07 ` [PATCH 15/23] drm: kill reclaim_buffers_locked Daniel Vetter
2011-10-27 11:07 ` [PATCH 16/23] drm/savage: clean up reclaim_buffers Daniel Vetter
2011-11-06 10:18   ` Tormod Volden
2011-10-27 11:07 ` [PATCH 17/23] drm: kill reclaim_buffers callback Daniel Vetter
2011-10-27 11:07 ` [PATCH 18/23] drm: ditch strange DRIVER_DMA_QUEUE only error bail-out Daniel Vetter
2011-10-27 11:07 ` [PATCH 19/23] drm: kill dma queue support Daniel Vetter
2011-10-27 11:07 ` [PATCH 20/23] drm: unconditionally clean up dma buffers of closing clients Daniel Vetter
2011-10-27 11:07 ` [PATCH 21/23] drm: kill i915/i830 ids from drm_pciids.h Daniel Vetter
2011-10-27 11:07 ` [PATCH 22/23] drm: kill procfs support Daniel Vetter
2011-10-27 11:07 ` [PATCH 23/23] drm: kill a few unused remnants from drm_memory.c Daniel Vetter
2011-11-11 15:33 ` [PATCH 00/23] kill drm cruft with fire James Simmons
2011-11-11 17:07   ` Daniel Vetter
2011-11-14 16:10     ` James Simmons
2011-11-16 16:17       ` Daniel Vetter
2011-12-05 10:14         ` Daniel Vetter
2011-12-07 14:19           ` James Simmons
2011-12-13 18:32             ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111027210009.GA4876@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox