From: Daniel Vetter <daniel@ffwll.ch>
To: Tormod Volden <lists.tormod@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 09/23] drm/sis: use drm_mm instead of drm_sman
Date: Sat, 29 Oct 2011 02:25:11 +0200 [thread overview]
Message-ID: <20111029002510.GE2919@phenom.ffwll.local> (raw)
In-Reply-To: <CAArsGaZXW41HAzqDRuJSYayHYA4pcU5dzCLGfoU8K-r_Dafm8g@mail.gmail.com>
On Sat, Oct 29, 2011 at 12:47:18AM +0200, Tormod Volden wrote:
> On Thu, Oct 27, 2011 at 1:07 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> ...
> > @@ -139,13 +99,35 @@ static int sis_drm_alloc(struct drm_device *dev, struct drm_file *file,
> ...
> > +#if defined(CONFIG_FB_SIS) || defined(CONFIG_FB_SIS_MODULE)
> > + item->req.size = mem->size;
> > + sis_malloc(&item->req);
> > + if (item->req.size == 0)
> > + retval = -ENOMEN;
>
> ENOMEN is omen, I guess this was not compile tested with either CONFIG?
Oh gosh, this is embarassing ;-) I've indeed fumbled this and forgotten to
check that config option. Smashed your patch on top of mine. btw, do you
have some actual hw to test this on, or have you just checked out of
curiosity?
Thanks, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-10-29 0:24 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 11:07 [PATCH 00/23] kill drm cruft with fire Daniel Vetter
2011-10-27 11:07 ` [PATCH 01/23] drm/sis: track obj->drm_fd relations in the driver Daniel Vetter
2011-10-27 11:07 ` [PATCH 02/23] drm/via: " Daniel Vetter
2011-12-07 16:21 ` James Simmons
2011-10-27 11:07 ` [PATCH 03/23] drm/sman: kill owner tracking interface functions Daniel Vetter
2011-12-07 16:21 ` James Simmons
2011-10-27 11:07 ` [PATCH 04/23] drm/sman: rip out owner tracking Daniel Vetter
2011-12-07 16:22 ` James Simmons
2011-10-27 11:07 ` [PATCH 05/23] drm/via: track user->memblock mapping with idr Daniel Vetter
2011-12-07 16:22 ` James Simmons
2011-10-27 11:07 ` [PATCH 06/23] drm/sis: " Daniel Vetter
2011-12-07 16:22 ` James Simmons
2011-10-27 11:07 ` [PATCH 07/23] drm/sman: kill user_hash_tab Daniel Vetter
2011-12-07 16:22 ` James Simmons
2011-10-27 11:07 ` [PATCH 08/23] drm/via: use drm_mm instead of drm_sman Daniel Vetter
2011-10-27 21:00 ` Daniel Vetter
2011-12-07 16:28 ` James Simmons
2011-12-12 22:51 ` Daniel Vetter
2011-12-07 16:23 ` James Simmons
2011-10-27 11:07 ` [PATCH 09/23] drm/sis: " Daniel Vetter
2011-10-28 22:47 ` Tormod Volden
2011-10-28 23:05 ` [PATCH] drm/sis: Fix building with CONFIG_FB_SIS/CONFIG_FB_SIS_MODULE Tormod Volden
2011-10-29 0:25 ` Daniel Vetter [this message]
2011-10-29 6:52 ` [PATCH 09/23] drm/sis: use drm_mm instead of drm_sman Tormod Volden
2011-10-29 9:44 ` Daniel Vetter
2011-12-07 16:23 ` James Simmons
2011-10-27 11:07 ` [PATCH 10/23] drm: kill drm_sman Daniel Vetter
2011-12-07 16:24 ` James Simmons
2011-10-27 11:07 ` [PATCH 11/23] drm/via: clean up reclaim_buffers Daniel Vetter
2011-12-08 0:26 ` James Simmons
2011-10-27 11:07 ` [PATCH 12/23] drm/sis: " Daniel Vetter
2011-10-27 11:07 ` [PATCH 13/23] drm: kill reclaim_buffers_idlelocked functions Daniel Vetter
2011-10-27 11:07 ` [PATCH 14/23] drm/i810: cleanup reclaim_buffers Daniel Vetter
2011-10-27 11:07 ` [PATCH 15/23] drm: kill reclaim_buffers_locked Daniel Vetter
2011-10-27 11:07 ` [PATCH 16/23] drm/savage: clean up reclaim_buffers Daniel Vetter
2011-11-06 10:18 ` Tormod Volden
2011-10-27 11:07 ` [PATCH 17/23] drm: kill reclaim_buffers callback Daniel Vetter
2011-10-27 11:07 ` [PATCH 18/23] drm: ditch strange DRIVER_DMA_QUEUE only error bail-out Daniel Vetter
2011-10-27 11:07 ` [PATCH 19/23] drm: kill dma queue support Daniel Vetter
2011-10-27 11:07 ` [PATCH 20/23] drm: unconditionally clean up dma buffers of closing clients Daniel Vetter
2011-10-27 11:07 ` [PATCH 21/23] drm: kill i915/i830 ids from drm_pciids.h Daniel Vetter
2011-10-27 11:07 ` [PATCH 22/23] drm: kill procfs support Daniel Vetter
2011-10-27 11:07 ` [PATCH 23/23] drm: kill a few unused remnants from drm_memory.c Daniel Vetter
2011-11-11 15:33 ` [PATCH 00/23] kill drm cruft with fire James Simmons
2011-11-11 17:07 ` Daniel Vetter
2011-11-14 16:10 ` James Simmons
2011-11-16 16:17 ` Daniel Vetter
2011-12-05 10:14 ` Daniel Vetter
2011-12-07 14:19 ` James Simmons
2011-12-13 18:32 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111029002510.GE2919@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=lists.tormod@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox