From: Daniel Vetter <daniel@ffwll.ch>
To: Adam Jackson <ajax@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
stable@kernel.org
Subject: Re: [PATCH] drm/i915: properly compute dp dithering for user-created modes
Date: Tue, 10 Apr 2012 19:23:32 +0200 [thread overview]
Message-ID: <20120410172332.GM4115@phenom.ffwll.local> (raw)
In-Reply-To: <4F8439CD.2020201@redhat.com>
On Tue, Apr 10, 2012 at 09:46:53AM -0400, Adam Jackson wrote:
> On 4/10/12 4:42 AM, Daniel Vetter wrote:
> >We've only computed whether we need to fall back to 6bpc due to dp
> >link bandwidth constrains in mode_valid, but not mode_fixup. Under
> >various circumstances X likes to create new modes which then lack
> >proper 6bpc flags (if required), resulting in mode_fixup failures and
> >ultimately black screens.
> >
> >Chris Wilson pointed out that we still get things wrong for bpp > 24,
> >but that should be fixed in another patch (and it'll be easier because
> >this patch consolidates the logic).
>
> Certainly an improvement.
>
> Reviewed-by: Adam Jackson <ajax@redhat.com>
I've picked this up for -fixes, thanks for the review.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-04-10 17:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 7:33 [PATCH] drm/i915: properly compute dp dithering for user-created modes Daniel Vetter
2012-04-10 8:14 ` Chris Wilson
2012-04-10 8:36 ` Daniel Vetter
2012-04-10 8:42 ` Daniel Vetter
2012-04-10 13:46 ` Adam Jackson
2012-04-10 17:23 ` Daniel Vetter [this message]
2012-04-10 17:26 ` [Intel-gfx] " Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410172332.GM4115@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ajax@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox