From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 1/9] drm: Make drm_num_cea_modes unsigned
Date: Mon, 14 Jan 2013 16:42:39 +0200 [thread overview]
Message-ID: <20130114144239.GF3867@intel.com> (raw)
In-Reply-To: <1358173828-31674-2-git-send-email-thierry.reding@avionic-design.de>
On Mon, Jan 14, 2013 at 03:30:20PM +0100, Thierry Reding wrote:
> Since the variable's value is the size of an array, we can assume that
> it will never be negative.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> ---
> drivers/gpu/drm/drm_edid_modes.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_edid_modes.h b/drivers/gpu/drm/drm_edid_modes.h
> index 5dbf7d2..d65d863 100644
> --- a/drivers/gpu/drm/drm_edid_modes.h
> +++ b/drivers/gpu/drm/drm_edid_modes.h
> @@ -771,4 +771,4 @@ static const struct drm_display_mode edid_cea_modes[] = {
> 2492, 2640, 0, 1080, 1084, 1094, 1125, 0,
> DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC) },
> };
> -static const int drm_num_cea_modes = ARRAY_SIZE(edid_cea_modes);
> +static const unsigned int drm_num_cea_modes = ARRAY_SIZE(edid_cea_modes);
Why do we even have these num_foo things? I think it would be clearer to
use ARRAY_SIZE(foo) directly where appropriate.
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-01-14 14:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 14:30 [PATCH v3 0/9] Add HDMI infoframe helpers Thierry Reding
2013-01-14 14:30 ` [PATCH v3 1/9] drm: Make drm_num_cea_modes unsigned Thierry Reding
2013-01-14 14:42 ` Ville Syrjälä [this message]
2013-01-14 15:06 ` Thierry Reding
2013-01-14 15:47 ` Ville Syrjälä
2013-01-18 10:30 ` Thierry Reding
2013-01-18 10:51 ` Ville Syrjälä
2013-01-18 11:08 ` Thierry Reding
2013-01-14 14:30 ` [PATCH v3 2/9] drm: Add some missing forward declarations Thierry Reding
2013-01-14 14:30 ` [PATCH v3 3/9] video: Add generic HDMI infoframe helpers Thierry Reding
2013-01-16 13:27 ` Ville Syrjälä
2013-01-18 8:56 ` Thierry Reding
2013-01-18 10:50 ` Ville Syrjälä
2013-01-14 14:30 ` [PATCH v3 4/9] drm: Add " Thierry Reding
2013-01-14 14:30 ` [PATCH v3 5/9] drm: Add EDID helper documentation Thierry Reding
2013-01-14 14:30 ` [PATCH v3 6/9] drm/tegra: Use generic HDMI infoframe helpers Thierry Reding
2013-01-14 14:30 ` [PATCH v3 7/9] drm/i915: " Thierry Reding
2013-01-14 14:30 ` [PATCH v3 8/9] drm/radeon: " Thierry Reding
2013-01-14 14:30 ` [PATCH v3 9/9] drm: Remove duplicate drm_mode_cea_vic() Thierry Reding
2013-01-14 14:57 ` Ville Syrjälä
2013-01-14 15:03 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114144239.GF3867@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox