From: Daniel Vetter <daniel@ffwll.ch>
To: ville.syrjala@linux.intel.com, Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm: Use C8 instead of RGB332 when determining the format from depth/bpp
Date: Mon, 4 Feb 2013 15:55:51 +0100 [thread overview]
Message-ID: <20130204145551.GD5843@phenom.ffwll.local> (raw)
In-Reply-To: <1359654218-31173-3-git-send-email-ville.syrjala@linux.intel.com>
On Thu, Jan 31, 2013 at 07:43:38PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Support for real RGB332 is a rarity, most hardware only really support
> C8. So use C8 instead of RGB332 when determining the format based on
> depth/bpp.
>
> This fixes 8bpp fbcon on i915, since i915 will only accept C8 and not
> RGB332.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59572
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Tested-by: mlsemon35@gmail.com
Dave, can you please consider including these two patches into -fixes? The
fix a black screen regression when users opt for 8bpp console ...
-Daniel
> ---
> drivers/gpu/drm/drm_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index ff7344c..826a5ca 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -2253,7 +2253,7 @@ uint32_t drm_mode_legacy_fb_format(uint32_t bpp, uint32_t depth)
>
> switch (bpp) {
> case 8:
> - fmt = DRM_FORMAT_RGB332;
> + fmt = DRM_FORMAT_C8;
> break;
> case 16:
> if (depth == 15)
> --
> 1.7.12.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-02-04 14:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 17:43 [PATCH 0/2] drm: Fix 8bpp fbcon on i915 ville.syrjala
2013-01-31 17:43 ` [PATCH 1/2] drm: Fill depth/bits_per_pixel for C8 format ville.syrjala
2013-01-31 17:43 ` [PATCH 2/2] drm: Use C8 instead of RGB332 when determining the format from depth/bpp ville.syrjala
2013-02-04 14:55 ` Daniel Vetter [this message]
2013-02-05 3:07 ` Dave Airlie
2013-02-13 12:40 ` Daniel Vetter
2013-02-13 23:45 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204145551.GD5843@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox