From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm: Use C8 instead of RGB332 when determining the format from depth/bpp
Date: Thu, 14 Feb 2013 00:45:53 +0100 [thread overview]
Message-ID: <20130213234553.GS5813@phenom.ffwll.local> (raw)
In-Reply-To: <20130213124056.GH5813@phenom.ffwll.local>
On Wed, Feb 13, 2013 at 01:40:56PM +0100, Daniel Vetter wrote:
> On Tue, Feb 05, 2013 at 01:07:01PM +1000, Dave Airlie wrote:
> > On Tue, Feb 5, 2013 at 12:55 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > On Thu, Jan 31, 2013 at 07:43:38PM +0200, ville.syrjala@linux.intel.com wrote:
> > >> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >>
> > >> Support for real RGB332 is a rarity, most hardware only really support
> > >> C8. So use C8 instead of RGB332 when determining the format based on
> > >> depth/bpp.
> > >>
> > >> This fixes 8bpp fbcon on i915, since i915 will only accept C8 and not
> > >> RGB332.
> > >>
> > >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59572
> > >> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Tested-by: mlsemon35@gmail.com
> > >
> > > Dave, can you please consider including these two patches into -fixes? The
> > > fix a black screen regression when users opt for 8bpp console ...
> >
> > These are for next, considering what Linus said about -fixes not
> > unless they are big.
> >
> > so I'll stick a stable cc onto it in next.
>
> Ping for merging into drm-next or acking for merging through
> drm-intel-next ...
Merged both into drm-intel trees for 3.9 with Dave's irc-ack.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-02-13 23:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 17:43 [PATCH 0/2] drm: Fix 8bpp fbcon on i915 ville.syrjala
2013-01-31 17:43 ` [PATCH 1/2] drm: Fill depth/bits_per_pixel for C8 format ville.syrjala
2013-01-31 17:43 ` [PATCH 2/2] drm: Use C8 instead of RGB332 when determining the format from depth/bpp ville.syrjala
2013-02-04 14:55 ` Daniel Vetter
2013-02-05 3:07 ` Dave Airlie
2013-02-13 12:40 ` Daniel Vetter
2013-02-13 23:45 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213234553.GS5813@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox