From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Fix comment referring to the long gone ->probe() connector vfunc
Date: Tue, 24 Sep 2013 12:33:50 +0200 [thread overview]
Message-ID: <20130924103350.GL13668@phenom.ffwll.local> (raw)
In-Reply-To: <1379944089-1622-1-git-send-email-damien.lespiau@intel.com>
On Mon, Sep 23, 2013 at 02:48:09PM +0100, Damien Lespiau wrote:
> drm_helper_probe_single_connector_modes() can be used to implement
> ->fill_modes(), not ->probe().
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_crtc_helper.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
> index 4280e37..5fcb9d4 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -109,9 +109,9 @@ static void drm_mode_validate_flag(struct drm_connector *connector,
> * then culled (based on validity and the @maxX, @maxY parameters) and put into
> * the normal modes list.
> *
> - * Intended to be use as a generic implementation of the ->probe() @connector
> - * callback for drivers that use the crtc helpers for output mode filtering and
> - * detection.
> + * Intended to be use as a generic implementation of the ->fill_modes()
> + * @connector vfunc for drivers that use the crtc helpers for output mode
> + * filtering and detection.
> *
> * RETURNS:
> * Number of modes found on @connector.
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-09-24 10:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 13:48 [PATCH] drm: Fix comment referring to the long gone ->probe() connector vfunc Damien Lespiau
2013-09-24 10:33 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924103350.GL13668@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox