* [PATCH] drm: Fix comment referring to the long gone ->probe() connector vfunc
@ 2013-09-23 13:48 Damien Lespiau
2013-09-24 10:33 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Damien Lespiau @ 2013-09-23 13:48 UTC (permalink / raw)
To: dri-devel
drm_helper_probe_single_connector_modes() can be used to implement
->fill_modes(), not ->probe().
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
drivers/gpu/drm/drm_crtc_helper.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index 4280e37..5fcb9d4 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -109,9 +109,9 @@ static void drm_mode_validate_flag(struct drm_connector *connector,
* then culled (based on validity and the @maxX, @maxY parameters) and put into
* the normal modes list.
*
- * Intended to be use as a generic implementation of the ->probe() @connector
- * callback for drivers that use the crtc helpers for output mode filtering and
- * detection.
+ * Intended to be use as a generic implementation of the ->fill_modes()
+ * @connector vfunc for drivers that use the crtc helpers for output mode
+ * filtering and detection.
*
* RETURNS:
* Number of modes found on @connector.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: Fix comment referring to the long gone ->probe() connector vfunc
2013-09-23 13:48 [PATCH] drm: Fix comment referring to the long gone ->probe() connector vfunc Damien Lespiau
@ 2013-09-24 10:33 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2013-09-24 10:33 UTC (permalink / raw)
To: Damien Lespiau; +Cc: dri-devel
On Mon, Sep 23, 2013 at 02:48:09PM +0100, Damien Lespiau wrote:
> drm_helper_probe_single_connector_modes() can be used to implement
> ->fill_modes(), not ->probe().
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_crtc_helper.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
> index 4280e37..5fcb9d4 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -109,9 +109,9 @@ static void drm_mode_validate_flag(struct drm_connector *connector,
> * then culled (based on validity and the @maxX, @maxY parameters) and put into
> * the normal modes list.
> *
> - * Intended to be use as a generic implementation of the ->probe() @connector
> - * callback for drivers that use the crtc helpers for output mode filtering and
> - * detection.
> + * Intended to be use as a generic implementation of the ->fill_modes()
> + * @connector vfunc for drivers that use the crtc helpers for output mode
> + * filtering and detection.
> *
> * RETURNS:
> * Number of modes found on @connector.
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-24 10:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 13:48 [PATCH] drm: Fix comment referring to the long gone ->probe() connector vfunc Damien Lespiau
2013-09-24 10:33 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox