Re: [PATCH 06/20] drm: move AGP definitions harder

[Daniel Vetter <daniel@ffwll.ch>]

On Fri, Aug 29, 2014 at 01:43:10PM +0200, Thierry Reding wrote:
> On Fri, Aug 29, 2014 at 12:12:32PM +0200, David Herrmann wrote:
> > Move drm_agp_head to drm_agpsupport.h and drm_agp_mem into drm_legacy.h.
> > Unfortunately, drivers still heavily access drm_agp_head so we cannot
> > move it to drm_legacy.h. However, at least it's no longer visible in
> > drmP.h now (it's directly included from it, though).
> > 
> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
> > ---
> >  drivers/gpu/drm/drm_agpsupport.c |  1 +
> >  drivers/gpu/drm/drm_legacy.h     | 15 +++++++++++++++
> >  drivers/gpu/drm/drm_memory.c     |  1 +
> >  drivers/gpu/drm/drm_vm.c         |  1 +
> >  include/drm/drmP.h               | 30 +-----------------------------
> >  include/drm/drm_agpsupport.h     | 13 +++++++++++++
> >  6 files changed, 32 insertions(+), 29 deletions(-)
> 
> I don't know exactly what you mean by "move harder" in the subject, but
> other than that this looks good, so with a better subject this is:

I guess "Try to hide AGP definitions harder" would be more accurate.
-Daniel

> 
> Reviewed-by: Thierry Reding <treding@nvidia.com>



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch