From: Gustavo Padovan <gustavo@padovan.org>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: sw0312.kim@samsung.com, gustavo.padovan@collabora.co.uk,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/exynos: fix NULL pointer reference
Date: Thu, 5 Feb 2015 11:07:27 -0200 [thread overview]
Message-ID: <20150205130727.GC21463@joana> (raw)
In-Reply-To: <1423120298-28619-4-git-send-email-jy0922.shim@samsung.com>
Hi,
2015-02-05 Joonyoung Shim <jy0922.shim@samsung.com>:
> There is a case called disable_plane callback function even if
> plane->crtc is NULL from exynos_drm_encoder_disable and it will cause
> NULL pointer reference error.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_encoder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You need to merge this patch with patch 3 or you will break the bisect.
The NULL pointer is introduced by the previous patch, so fix it in the same
patch.
Once that is fixed:
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
for the whole series.
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-02-05 13:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 7:11 [PATCH 1/4] drm/exynos: Remove exynos_plane_dpms() call with no effect Joonyoung Shim
2015-02-05 7:11 ` [PATCH 2/4] drm/exynos: remove mode property of exynos crtc Joonyoung Shim
2015-02-05 7:11 ` [PATCH 3/4] drm/exynos: remove exynos_plane_dpms Joonyoung Shim
2015-02-05 7:11 ` [PATCH 4/4] drm/exynos: fix NULL pointer reference Joonyoung Shim
2015-02-05 13:07 ` Gustavo Padovan [this message]
2015-02-06 3:45 ` Joonyoung Shim
2015-02-06 12:44 ` Gustavo Padovan
2015-02-11 11:36 ` Inki Dae
2015-02-05 9:40 ` [PATCH 1/4] drm/exynos: Remove exynos_plane_dpms() call with no effect Daniel Vetter
2015-02-06 3:48 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205130727.GC21463@joana \
--to=gustavo@padovan.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=jy0922.shim@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox