Re: [PATCH 1/4] drm/exynos: Remove exynos_plane_dpms() call with no effect

[Joonyoung Shim <jy0922.shim@samsung.com>]

Hi,

On 02/05/2015 06:40 PM, Daniel Vetter wrote:
> On Thu, Feb 05, 2015 at 04:11:35PM +0900, Joonyoung Shim wrote:
>> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>
>> exynos_plane_dpms(DRM_MODE_DPMS_ON) calls the win_enable()'s callback
>> from the underlying layer. However neither one of these layers implement
>> win_enable() - FIMD, Mixer and VIDI. Thus the call to exynos_plane_dpms()
>> is pointless.
>>
>> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> I guess you want to apply this patch after patch 2&3 for bisecting. But

Yeah, but i just applied this than modify original patch.

> makes sense otherwise. For the entire series:
> 
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Thanks.

>> ---
>>  drivers/gpu/drm/exynos/exynos_drm_crtc.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
>> index a85c451..fff2e55 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
>> @@ -66,8 +66,6 @@ static void exynos_drm_crtc_commit(struct drm_crtc *crtc)
>>  
>>  	if (exynos_crtc->ops->commit)
>>  		exynos_crtc->ops->commit(exynos_crtc);
>> -
>> -	exynos_plane_dpms(crtc->primary, DRM_MODE_DPMS_ON);
>>  }
>>  
>>  static bool
>> -- 
>> 1.9.1
>>
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel