From: Inki Dae <inki.dae@samsung.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: gustavo.padovan@collabora.co.uk, sw0312.kim@samsung.com,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/exynos: fix NULL pointer reference
Date: Wed, 11 Feb 2015 20:36:59 +0900 [thread overview]
Message-ID: <54DB3EDB.3040101@samsung.com> (raw)
In-Reply-To: <1423120298-28619-4-git-send-email-jy0922.shim@samsung.com>
On 2015년 02월 05일 16:11, Joonyoung Shim wrote:
> There is a case called disable_plane callback function even if
> plane->crtc is NULL from exynos_drm_encoder_disable and it will cause
> NULL pointer reference error.
Applied. (patch 1 though 4)
Thanks,
Inki Dae
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_encoder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
> index 7e282e3..57de0bd 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
> @@ -102,7 +102,7 @@ static void exynos_drm_encoder_disable(struct drm_encoder *encoder)
>
> /* all planes connected to this encoder should be also disabled. */
> drm_for_each_legacy_plane(plane, &dev->mode_config.plane_list) {
> - if (plane->crtc == encoder->crtc)
> + if (plane->crtc && (plane->crtc == encoder->crtc))
> plane->funcs->disable_plane(plane);
> }
> }
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-02-11 11:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 7:11 [PATCH 1/4] drm/exynos: Remove exynos_plane_dpms() call with no effect Joonyoung Shim
2015-02-05 7:11 ` [PATCH 2/4] drm/exynos: remove mode property of exynos crtc Joonyoung Shim
2015-02-05 7:11 ` [PATCH 3/4] drm/exynos: remove exynos_plane_dpms Joonyoung Shim
2015-02-05 7:11 ` [PATCH 4/4] drm/exynos: fix NULL pointer reference Joonyoung Shim
2015-02-05 13:07 ` Gustavo Padovan
2015-02-06 3:45 ` Joonyoung Shim
2015-02-06 12:44 ` Gustavo Padovan
2015-02-11 11:36 ` Inki Dae [this message]
2015-02-05 9:40 ` [PATCH 1/4] drm/exynos: Remove exynos_plane_dpms() call with no effect Daniel Vetter
2015-02-06 3:48 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB3EDB.3040101@samsung.com \
--to=inki.dae@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=jy0922.shim@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox