From: Daniel Vetter <daniel@ffwll.ch>
To: Vincent Abriou <vincent.abriou@st.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Fabien Dessenne <fabien.dessenne@st.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 00/10] drm/sti: debugfs
Date: Fri, 22 Apr 2016 15:29:06 +0200 [thread overview]
Message-ID: <20160422132906.GZ2510@phenom.ffwll.local> (raw)
In-Reply-To: <1455268449-686-1-git-send-email-vincent.abriou@st.com>
On Fri, Feb 12, 2016 at 10:13:59AM +0100, Vincent Abriou wrote:
> Those patches introduce debugfs for connector, encoder, crtc and planes.
> It adds the following entries:
> - planes:
> gdpx / gdpx_node
> hqvdp
> cursor
> vid
> fps_get / fps_show
>
> - crtc:
> mixer_aux / mixer_main
>
> - encoder:
> tvout
>
> - connectors:
> hda
> hdmi
> dvo
Just noticed that all your debugfs files lock dev->struct_mutex. That's
pure cargo-cult garbage. Please fix asap and replace the useless locking
you have with the right ones where needed (e.g. modeset structures where
never protected by dev->struct_mutex). Did someone bother to review the
locking in these patches?
Thanks, Daniel
>
> Vincent Abriou (10):
> drm/sti: add debugfs entries for HDMI connector
> drm/sti: add debugfs entries for DVO connector
> drm/sti: add debugfs entries for HDA connector
> drm/sti: add debugfs entries for CURSOR plane
> drm/sti: add debugfs entries for GDP planes
> drm/sti: add debugfs entries for HQVDP plane
> drm/sti: add debugfs entries for VID plane
> drm/sti: add debugfs entries for MIXER crtc
> drm/sti: add debugfs entries for TVOUT encoders
> drm/sti: add debugfs fps_show/fps_get mechanism for planes
>
> drivers/gpu/drm/sti/sti_compositor.c | 4 +-
> drivers/gpu/drm/sti/sti_cursor.c | 81 +++++++++++
> drivers/gpu/drm/sti/sti_drv.c | 128 ++++++++++++++++++
> drivers/gpu/drm/sti/sti_dvo.c | 70 ++++++++++
> drivers/gpu/drm/sti/sti_gdp.c | 238 ++++++++++++++++++++++++++++++++
> drivers/gpu/drm/sti/sti_hda.c | 105 ++++++++++++++-
> drivers/gpu/drm/sti/sti_hdmi.c | 175 +++++++++++++++++++++++-
> drivers/gpu/drm/sti/sti_hdmi.h | 4 +-
> drivers/gpu/drm/sti/sti_hqvdp.c | 254 ++++++++++++++++++++++++++++++++++-
> drivers/gpu/drm/sti/sti_mixer.c | 146 +++++++++++++++++++-
> drivers/gpu/drm/sti/sti_mixer.h | 4 +-
> drivers/gpu/drm/sti/sti_plane.c | 63 +++++++++
> drivers/gpu/drm/sti/sti_plane.h | 17 +++
> drivers/gpu/drm/sti/sti_tvout.c | 157 ++++++++++++++++++++++
> drivers/gpu/drm/sti/sti_vid.c | 94 ++++++++++++-
> drivers/gpu/drm/sti/sti_vid.h | 4 +-
> 16 files changed, 1524 insertions(+), 20 deletions(-)
>
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-04-22 13:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 9:13 [PATCH 00/10] drm/sti: debugfs Vincent Abriou
2016-02-12 9:14 ` [PATCH 01/10] drm/sti: add debugfs entries for HDMI connector Vincent Abriou
2016-02-12 9:14 ` [PATCH 02/10] drm/sti: add debugfs entries for DVO connector Vincent Abriou
2016-02-12 9:14 ` [PATCH 03/10] drm/sti: add debugfs entries for HDA connector Vincent Abriou
2016-02-12 9:14 ` [PATCH 04/10] drm/sti: add debugfs entries for CURSOR plane Vincent Abriou
2016-02-12 9:14 ` [PATCH 05/10] drm/sti: add debugfs entries for GDP planes Vincent Abriou
2016-02-12 9:14 ` [PATCH 06/10] drm/sti: add debugfs entries for HQVDP plane Vincent Abriou
2016-02-12 9:14 ` [PATCH 07/10] drm/sti: add debugfs entries for VID plane Vincent Abriou
2016-02-12 9:14 ` [PATCH 08/10] drm/sti: add debugfs entries for MIXER crtc Vincent Abriou
2016-02-12 9:14 ` [PATCH 09/10] drm/sti: add debugfs entries for TVOUT encoders Vincent Abriou
2016-02-12 9:14 ` [PATCH 10/10] drm/sti: add debugfs fps_show/fps_get mechanism for planes Vincent Abriou
2016-04-22 13:29 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422132906.GZ2510@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabien.dessenne@st.com \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox