* [PATCH] drm/atomic: Update comment to match the code
@ 2017-07-31 9:13 Thierry Reding
2017-07-31 10:53 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2017-07-31 9:13 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, Sean Paul; +Cc: dri-devel
From: Thierry Reding <treding@nvidia.com>
The kerneldoc for drm_atomic_crtc_needs_modeset() is outdated and no
longer reflects the actual code. Fix that up to remove confusion.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
include/drm/drm_atomic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
index 7cd0f303f5a3..a7adbf57b886 100644
--- a/include/drm/drm_atomic.h
+++ b/include/drm/drm_atomic.h
@@ -883,7 +883,7 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p);
*
* To give drivers flexibility &struct drm_crtc_state has 3 booleans to track
* whether the state CRTC changed enough to need a full modeset cycle:
- * planes_changed, mode_changed and active_changed. This helper simply
+ * mode_changed, active_changed and connectors_changed. This helper simply
* combines these three to compute the overall need for a modeset for @state.
*
* The atomic helper code sets these booleans, but drivers can and should
--
2.13.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/atomic: Update comment to match the code
2017-07-31 9:13 [PATCH] drm/atomic: Update comment to match the code Thierry Reding
@ 2017-07-31 10:53 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2017-07-31 10:53 UTC (permalink / raw)
To: Thierry Reding; +Cc: Daniel Vetter, dri-devel
On Mon, Jul 31, 2017 at 11:13:43AM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The kerneldoc for drm_atomic_crtc_needs_modeset() is outdated and no
> longer reflects the actual code. Fix that up to remove confusion.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Pls push to drm-misc-next.
-Daniel
> ---
> include/drm/drm_atomic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
> index 7cd0f303f5a3..a7adbf57b886 100644
> --- a/include/drm/drm_atomic.h
> +++ b/include/drm/drm_atomic.h
> @@ -883,7 +883,7 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p);
> *
> * To give drivers flexibility &struct drm_crtc_state has 3 booleans to track
> * whether the state CRTC changed enough to need a full modeset cycle:
> - * planes_changed, mode_changed and active_changed. This helper simply
> + * mode_changed, active_changed and connectors_changed. This helper simply
> * combines these three to compute the overall need for a modeset for @state.
> *
> * The atomic helper code sets these booleans, but drivers can and should
> --
> 2.13.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-31 10:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-31 9:13 [PATCH] drm/atomic: Update comment to match the code Thierry Reding
2017-07-31 10:53 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox