From: Thierry Reding <thierry.reding@gmail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: airlied@linux.ie, jagannadh.teki@gmail.com,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: simple: fix data type in KEO TX31D200VM0BAA timings
Date: Fri, 18 May 2018 12:18:37 +0200 [thread overview]
Message-ID: <20180518101837.GB5312@ulmo> (raw)
In-Reply-To: <20180419212003.8155-1-stefan@agner.ch>
[-- Attachment #1.1: Type: text/plain, Size: 1022 bytes --]
On Thu, Apr 19, 2018 at 11:20:03PM +0200, Stefan Agner wrote:
> All values in a struct struct timing_entry (every entry in
> struct display_timing) require an integer. Choose the closest
> safe integer of 32.
>
> This avoids a warning seen with clang:
> drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit
> conversion from 'double' to 'u32' (aka 'unsigned int')
> changes value from 33.5 to 33 [-Wliteral-conversion]
> .vfront_porch = { 6, 21, 33.5 },
> ~ ^~~~
> drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit
> conversion from 'double' to 'u32' (aka 'unsigned int')
> changes value from 33.5 to 33 [-Wliteral-conversion]
> .vback_porch = { 6, 21, 33.5 },
> ~ ^~~~
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-05-18 10:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 21:20 [PATCH] drm/panel: simple: fix data type in KEO TX31D200VM0BAA timings Stefan Agner
2018-05-18 10:18 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518101837.GB5312@ulmo \
--to=thierry.reding@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagannadh.teki@gmail.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox