[PATCH] drm/panel: simple: fix data type in KEO TX31D200VM0BAA timings

[PATCH] drm/panel: simple: fix data type in KEO TX31D200VM0BAA timings

[Stefan Agner]

All values in a struct struct timing_entry (every entry in
struct display_timing) require an integer. Choose the closest
safe integer of 32.

This avoids a warning seen with clang:
  drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit
       conversion from 'double' to 'u32' (aka 'unsigned int')
       changes value from 33.5 to 33 [-Wliteral-conversion]
         .vfront_porch = { 6, 21, 33.5 },
                         ~        ^~~~
  drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit
        conversion from 'double' to 'u32' (aka 'unsigned int')
        changes value from 33.5 to 33 [-Wliteral-conversion]
          .vback_porch = { 6, 21, 33.5 },
                         ~        ^~~~

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 drivers/gpu/drm/panel/panel-simple.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index cbf1ab404ee7..12bcbd1dd77b 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1247,8 +1247,8 @@ static const struct display_timing koe_tx31d200vm0baa_timing = {
 	.hback_porch = { 16, 36, 56 },
 	.hsync_len = { 8, 8, 8 },
 	.vactive = { 480, 480, 480 },
-	.vfront_porch = { 6, 21, 33.5 },
-	.vback_porch = { 6, 21, 33.5 },
+	.vfront_porch = { 6, 21, 33 },
+	.vback_porch = { 6, 21, 33 },
 	.vsync_len = { 8, 8, 8 },
 	.flags = DISPLAY_FLAGS_DE_HIGH,
 };
-- 
2.17.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/panel: simple: fix data type in KEO TX31D200VM0BAA timings

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 1022 bytes --]

On Thu, Apr 19, 2018 at 11:20:03PM +0200, Stefan Agner wrote:
> All values in a struct struct timing_entry (every entry in
> struct display_timing) require an integer. Choose the closest
> safe integer of 32.
> 
> This avoids a warning seen with clang:
>   drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit
>        conversion from 'double' to 'u32' (aka 'unsigned int')
>        changes value from 33.5 to 33 [-Wliteral-conversion]
>          .vfront_porch = { 6, 21, 33.5 },
>                          ~        ^~~~
>   drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit
>         conversion from 'double' to 'u32' (aka 'unsigned int')
>         changes value from 33.5 to 33 [-Wliteral-conversion]
>           .vback_porch = { 6, 21, 33.5 },
>                          ~        ^~~~
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel