From: Daniel Vetter <daniel@ffwll.ch>
To: Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 7/9] drm/gem-fb-helper: Always do implicit sync
Date: Wed, 20 Jun 2018 14:46:44 +0200 [thread overview]
Message-ID: <20180620124643.GA19791@phenom.ffwll.local> (raw)
In-Reply-To: <20180424120410.GV31310@phenom.ffwll.local>
On Tue, Apr 24, 2018 at 02:04:10PM +0200, Daniel Vetter wrote:
> On Fri, Apr 20, 2018 at 03:11:24PM -0700, Eric Anholt wrote:
> > Daniel Vetter <daniel.vetter@ffwll.ch> writes:
> >
> > > I've done a lot of history digging. The first signs of this
> > > optimization was introduced in i915:
> >
> > I can't come up with any reason this would matter. I almost came up
> > with "You're doing tearing X11 front buffer rendering, and you do a
> > modeset using the same fb, and so you block that modeset behind your
> > rendering." Except that:
> >
> > 1) who cares
> > 2) this helper is only for dma-bufs, not normal X11 rendering
> > 3) your X11 driver should be doing pageflipping to be tear-free anyway,
> > let's just fix that[1].
> >
> > Reviewed-by: Eric Anholt <eric@anholt.net>
> >
> > [1] This is not actually me volunteering myself or anyone else to go fix
> > that.
>
> Ok, merged everything except the final three patches. I'll poke Rob for a
> proper ack first before doing that. There's not much point in trying to
> unify behaviour if there's still a driver doing things differently :-)
>
> Thanks very much for your review.
Ok with the msm conversion to atomic commit helpers msm aligned to what
we're doing here without my patch. I pulled in the remaining to for 4.19.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-06-20 12:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 15:44 [PATCH 0/9] implicit fencing clarification Daniel Vetter
2018-04-05 15:44 ` [PATCH 1/9] drm/vmwgfx: Remove no-op prepare/cleanup_fb callbacks Daniel Vetter
2018-04-05 17:06 ` Thomas Hellstrom
2018-04-05 19:59 ` Daniel Vetter
2018-04-05 15:44 ` [PATCH 2/9] drm: Move simple_display_pipe prepare_fb helper into gem fb helpers Daniel Vetter
2018-04-06 9:42 ` Noralf Trønnes
2018-04-09 8:42 ` Daniel Vetter
2018-04-09 15:23 ` David Lechner
2018-04-10 5:55 ` Oleksandr Andrushchenko
2018-04-05 15:44 ` [PATCH 3/9] drm/tve200: Use simple_display_pipe prepare_fb helper Daniel Vetter
2018-04-06 9:40 ` Linus Walleij
2018-04-05 15:44 ` [PATCH 4/9] drm/pl111: " Daniel Vetter
2018-04-05 15:44 ` [PATCH 5/9] drm/mxsfb: " Daniel Vetter
2018-04-20 21:54 ` Eric Anholt
2018-04-05 15:44 ` [PATCH 6/9] drm/atomic: better doc for implicit vs explicit fencing Daniel Vetter
2018-04-20 22:04 ` Eric Anholt
2018-04-24 12:01 ` Daniel Vetter
2018-04-05 15:44 ` [PATCH 7/9] drm/gem-fb-helper: Always do implicit sync Daniel Vetter
2018-04-20 22:11 ` Eric Anholt
2018-04-24 12:04 ` Daniel Vetter
2018-06-20 12:46 ` Daniel Vetter [this message]
2018-04-05 15:44 ` [PATCH 8/9] drm/vc4: Always obey " Daniel Vetter
2018-04-20 22:12 ` Eric Anholt
[not found] ` <20180405154449.23038-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-04-05 15:44 ` [PATCH 9/9] drm/msm: Always obey implicit fencing Daniel Vetter
[not found] ` <20180405154449.23038-10-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-06-20 9:12 ` Daniel Vetter
2018-04-06 7:38 ` [PATCH 0/9] implicit fencing clarification Oleksandr Andrushchenko
2018-04-09 8:44 ` Daniel Vetter
2018-04-09 8:51 ` [PATCH] drm/xen-front: use simple display pipe prepare_fb helper Daniel Vetter
2018-04-10 5:56 ` Oleksandr Andrushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620124643.GA19791@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=gustavo.padovan@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox