From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
xen-devel@lists.xen.org,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH] drm/xen-front: use simple display pipe prepare_fb helper
Date: Tue, 10 Apr 2018 08:56:26 +0300 [thread overview]
Message-ID: <94f2ffde-a8b4-27db-b647-e04aa541e532@gmail.com> (raw)
In-Reply-To: <20180409085134.27321-1-daniel.vetter@ffwll.ch>
On 04/09/2018 11:51 AM, Daniel Vetter wrote:
> I missed this one because on an older tree.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Cc: xen-devel@lists.xen.org
> ---
> drivers/gpu/drm/xen/xen_drm_front_kms.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c
> index 0bd6681fa4f3..a3479eb72d79 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_kms.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c
> @@ -226,12 +226,6 @@ static bool display_send_page_flip(struct drm_simple_display_pipe *pipe,
> return false;
> }
>
> -static int display_prepare_fb(struct drm_simple_display_pipe *pipe,
> - struct drm_plane_state *plane_state)
> -{
> - return drm_gem_fb_prepare_fb(&pipe->plane, plane_state);
> -}
> -
> static void display_update(struct drm_simple_display_pipe *pipe,
> struct drm_plane_state *old_plane_state)
> {
> @@ -294,7 +288,7 @@ static const struct drm_simple_display_pipe_funcs display_funcs = {
> .mode_valid = display_mode_valid,
> .enable = display_enable,
> .disable = display_disable,
> - .prepare_fb = display_prepare_fb,
> + .prepare_fb = drm_gem_fb_simple_display_pipe_prepare_fb,
> .update = display_update,
> };
>
Thank you,
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-04-10 5:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 15:44 [PATCH 0/9] implicit fencing clarification Daniel Vetter
2018-04-05 15:44 ` [PATCH 1/9] drm/vmwgfx: Remove no-op prepare/cleanup_fb callbacks Daniel Vetter
2018-04-05 17:06 ` Thomas Hellstrom
2018-04-05 19:59 ` Daniel Vetter
2018-04-05 15:44 ` [PATCH 2/9] drm: Move simple_display_pipe prepare_fb helper into gem fb helpers Daniel Vetter
2018-04-06 9:42 ` Noralf Trønnes
2018-04-09 8:42 ` Daniel Vetter
2018-04-09 15:23 ` David Lechner
2018-04-10 5:55 ` Oleksandr Andrushchenko
2018-04-05 15:44 ` [PATCH 3/9] drm/tve200: Use simple_display_pipe prepare_fb helper Daniel Vetter
2018-04-06 9:40 ` Linus Walleij
2018-04-05 15:44 ` [PATCH 4/9] drm/pl111: " Daniel Vetter
2018-04-05 15:44 ` [PATCH 5/9] drm/mxsfb: " Daniel Vetter
2018-04-20 21:54 ` Eric Anholt
2018-04-05 15:44 ` [PATCH 6/9] drm/atomic: better doc for implicit vs explicit fencing Daniel Vetter
2018-04-20 22:04 ` Eric Anholt
2018-04-24 12:01 ` Daniel Vetter
2018-04-05 15:44 ` [PATCH 7/9] drm/gem-fb-helper: Always do implicit sync Daniel Vetter
2018-04-20 22:11 ` Eric Anholt
2018-04-24 12:04 ` Daniel Vetter
2018-06-20 12:46 ` Daniel Vetter
2018-04-05 15:44 ` [PATCH 8/9] drm/vc4: Always obey " Daniel Vetter
2018-04-20 22:12 ` Eric Anholt
[not found] ` <20180405154449.23038-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-04-05 15:44 ` [PATCH 9/9] drm/msm: Always obey implicit fencing Daniel Vetter
[not found] ` <20180405154449.23038-10-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-06-20 9:12 ` Daniel Vetter
2018-04-06 7:38 ` [PATCH 0/9] implicit fencing clarification Oleksandr Andrushchenko
2018-04-09 8:44 ` Daniel Vetter
2018-04-09 8:51 ` [PATCH] drm/xen-front: use simple display pipe prepare_fb helper Daniel Vetter
2018-04-10 5:56 ` Oleksandr Andrushchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94f2ffde-a8b4-27db-b647-e04aa541e532@gmail.com \
--to=andr2000@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox