From: Jackie Liu <liu.yun@linux.dev>
To: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie
Cc: architt@codeaurora.org, liu.yun@linux.dev,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
christian.koenig@amd.com, chandanu@codeaurora.org
Subject: [PATCH 1/3] drm/msm/hdmi: fix build without CONFIG_COMMON_CLK
Date: Wed, 10 Nov 2021 15:09:48 +0800 [thread overview]
Message-ID: <20211110070950.3355597-1-liu.yun@linux.dev> (raw)
From: Jackie Liu <liuyun01@kylinos.cn>
HDMI 8996 PHY/PLL support need common clk. avoid like:
[...]
x86_64-linux-gnu-ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3e0): undefined reference to `msm_hdmi_phy_8996_cfg'
Fixes: e17afdceb4f2 ("drm/msm/hdmi: HDMI 8996 PHY/PLL support")
Reported-by: kernelbot <kernel-bot@kylinos.cn>
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy.c
index 16b0e8836d27..84d7f79f1aa8 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_phy.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy.c
@@ -192,8 +192,10 @@ static const struct of_device_id msm_hdmi_phy_dt_match[] = {
.data = &msm_hdmi_phy_8x74_cfg },
{ .compatible = "qcom,hdmi-phy-8084",
.data = &msm_hdmi_phy_8x74_cfg },
+#ifdef CONFIG_COMMON_CLK
{ .compatible = "qcom,hdmi-phy-8996",
.data = &msm_hdmi_phy_8996_cfg },
+#endif
{}
};
--
2.25.1
next reply other threads:[~2021-11-10 7:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 7:09 Jackie Liu [this message]
2021-11-10 7:09 ` [PATCH 2/3] drm/msm/dp: displayPort driver need algorithm rational Jackie Liu
2021-11-10 7:09 ` [PATCH 3/3] drm/msm: some features need to be forced to rely on COMMON_CLK Jackie Liu
2021-11-10 7:29 ` [PATCH 1/3] drm/msm/hdmi: fix build without CONFIG_COMMON_CLK Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110070950.3355597-1-liu.yun@linux.dev \
--to=liu.yun@linux.dev \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=chandanu@codeaurora.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox