Re: [PATCH 1/3] drm/msm/hdmi: fix build without CONFIG_COMMON_CLK

["Christian König" <christian.koenig@amd.com>]

Am 10.11.21 um 08:09 schrieb Jackie Liu:
> From: Jackie Liu <liuyun01@kylinos.cn>
>
> HDMI 8996 PHY/PLL support need common clk. avoid like:
>
> [...]
> x86_64-linux-gnu-ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3e0): undefined reference to `msm_hdmi_phy_8996_cfg'
>
> Fixes: e17afdceb4f2 ("drm/msm/hdmi: HDMI 8996 PHY/PLL support")
> Reported-by: kernelbot <kernel-bot@kylinos.cn>
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>

Since it is probably my fault that you stumbled over all that stuff here 
is an "Acked-by: Christian König <christian.koenig@amd.com>" for the 
full series.

But you certainly also need to maintainers or Dave/Daniel take a look.

Regards,
Christian.

> ---
>   drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy.c
> index 16b0e8836d27..84d7f79f1aa8 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy.c
> @@ -192,8 +192,10 @@ static const struct of_device_id msm_hdmi_phy_dt_match[] = {
>   	  .data = &msm_hdmi_phy_8x74_cfg },
>   	{ .compatible = "qcom,hdmi-phy-8084",
>   	  .data = &msm_hdmi_phy_8x74_cfg },
> +#ifdef CONFIG_COMMON_CLK
>   	{ .compatible = "qcom,hdmi-phy-8996",
>   	  .data = &msm_hdmi_phy_8996_cfg },
> +#endif
>   	{}
>   };
>