dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jackie Liu <liu.yun@linux.dev>
To: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie
Cc: architt@codeaurora.org, liu.yun@linux.dev,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	christian.koenig@amd.com, chandanu@codeaurora.org
Subject: [PATCH 3/3] drm/msm: some features need to be forced to rely on COMMON_CLK
Date: Wed, 10 Nov 2021 15:09:50 +0800	[thread overview]
Message-ID: <20211110070950.3355597-3-liu.yun@linux.dev> (raw)
In-Reply-To: <20211110070950.3355597-1-liu.yun@linux.dev>

From: Jackie Liu <liuyun01@kylinos.cn>

In fact, this will not cause any problems, but when COMPILE_TEST is
enabled, COMMON_CLK may not be selected, The CI system will report
some compilation errors. even if that is not issue, but we better fix
him.

[...]
x86_64-linux-gnu-ld: drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.o: in function `pll_28nm_register':
dsi_phy_28nm.c:(.text+0x868): undefined reference to `devm_clk_hw_register'
x86_64-linux-gnu-ld: dsi_phy_28nm.c:(.text+0x90c): undefined reference to `__devm_clk_hw_register_divider'
x86_64-linux-gnu-ld: dsi_phy_28nm.c:(.text+0x979): undefined reference to `devm_clk_hw_register_fixed_factor'
x86_64-linux-gnu-ld: dsi_phy_28nm.c:(.text+0x9f8): undefined reference to `__devm_clk_hw_register_divider'
x86_64-linux-gnu-ld: dsi_phy_28nm.c:(.text+0xab5): undefined reference to `__devm_clk_hw_register_mux'
x86_64-linux-gnu-ld: dsi_phy_28nm.c:(.text+0xb1e): undefined reference to `devm_clk_hw_register_fixed_factor'
x86_64-linux-gnu-ld: drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.o: in function `dsi_28nm_pll_save_state':
dsi_phy_28nm.c:(.text+0x1234): undefined reference to `clk_hw_get_rate'
x86_64-linux-gnu-ld: drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.o: in function `dsi_28nm_pll_save_state':
dsi_phy_28nm_8960.c:(.text+0x408): undefined reference to `clk_hw_get_rate'
x86_64-linux-gnu-ld: drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.o: in function `clk_bytediv_round_rate':
dsi_phy_28nm_8960.c:(.text+0x483): undefined reference to `clk_hw_get_parent'
x86_64-linux-gnu-ld: dsi_phy_28nm_8960.c:(.text+0x48e): undefined reference to `clk_hw_round_rate'
x86_64-linux-gnu-ld: drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.o: in function `pll_28nm_register':
dsi_phy_28nm_8960.c:(.text+0x681): undefined reference to `devm_clk_hw_register'
x86_64-linux-gnu-ld: dsi_phy_28nm_8960.c:(.text+0x735): undefined reference to `devm_clk_hw_register'
x86_64-linux-gnu-ld: dsi_phy_28nm_8960.c:(.text+0x796): undefined reference to `__devm_clk_hw_register_divider'
x86_64-linux-gnu-ld: drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.o: in function `pll_10nm_register':
dsi_phy_10nm.c:(.text+0x705): undefined reference to `devm_clk_hw_register'
x86_64-linux-gnu-ld: dsi_phy_10nm.c:(.text+0x7b0): undefined reference to `__devm_clk_hw_register_divider'
x86_64-linux-gnu-ld: dsi_phy_10nm.c:(.text+0x83a): undefined reference to `__devm_clk_hw_register_divider'
x86_64-linux-gnu-ld: dsi_phy_10nm.c:(.text+0x8ad): undefined reference to `devm_clk_hw_register_fixed_factor'
x86_64-linux-gnu-ld: dsi_phy_10nm.c:(.text+0x91d): undefined reference to `devm_clk_hw_register_fixed_factor'
x86_64-linux-gnu-ld: dsi_phy_10nm.c:(.text+0x989): undefined reference to `devm_clk_hw_register_fixed_factor'
x86_64-linux-gnu-ld: dsi_phy_10nm.c:(.text+0xaa4): undefined reference to `__devm_clk_hw_register_mux'
x86_64-linux-gnu-ld: dsi_phy_10nm.c:(.text+0xb2a): undefined reference to `__devm_clk_hw_register_divider'
x86_64-linux-gnu-ld: drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.o: in function `pll_7nm_register':
dsi_phy_7nm.c:(.text+0xa45): undefined reference to `devm_clk_hw_register'
x86_64-linux-gnu-ld: dsi_phy_7nm.c:(.text+0xaf0): undefined reference to `__devm_clk_hw_register_divider'
x86_64-linux-gnu-ld: dsi_phy_7nm.c:(.text+0xb7a): undefined reference to `__devm_clk_hw_register_divider'
x86_64-linux-gnu-ld: dsi_phy_7nm.c:(.text+0xbfd): undefined reference to `devm_clk_hw_register_fixed_factor'
x86_64-linux-gnu-ld: dsi_phy_7nm.c:(.text+0xc6d): undefined reference to `devm_clk_hw_register_fixed_factor'
x86_64-linux-gnu-ld: dsi_phy_7nm.c:(.text+0xcea): undefined reference to `devm_clk_hw_register_fixed_factor'
x86_64-linux-gnu-ld: dsi_phy_7nm.c:(.text+0xda0): undefined reference to `__devm_clk_hw_register_divider'
x86_64-linux-gnu-ld: dsi_phy_7nm.c:(.text+0xed9): undefined reference to `__devm_clk_hw_register_mux'
[...]

Fixes: b3ed524f84f5 ("drm/msm: allow compile_test on !ARM")
Reported-by: kernelbot <kernel-bot@kylinos.cn>
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
 drivers/gpu/drm/msm/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
index 617dcb799156..db5909ecca8e 100644
--- a/drivers/gpu/drm/msm/Kconfig
+++ b/drivers/gpu/drm/msm/Kconfig
@@ -85,6 +85,7 @@ config DRM_MSM_DSI
 config DRM_MSM_DSI_28NM_PHY
 	bool "Enable DSI 28nm PHY driver in MSM DRM"
 	depends on DRM_MSM_DSI
+	depends on COMMON_CLK
 	default y
 	help
 	  Choose this option if the 28nm DSI PHY is used on the platform.
@@ -92,6 +93,7 @@ config DRM_MSM_DSI_28NM_PHY
 config DRM_MSM_DSI_20NM_PHY
 	bool "Enable DSI 20nm PHY driver in MSM DRM"
 	depends on DRM_MSM_DSI
+	depends on COMMON_CLK
 	default y
 	help
 	  Choose this option if the 20nm DSI PHY is used on the platform.
@@ -99,6 +101,7 @@ config DRM_MSM_DSI_20NM_PHY
 config DRM_MSM_DSI_28NM_8960_PHY
 	bool "Enable DSI 28nm 8960 PHY driver in MSM DRM"
 	depends on DRM_MSM_DSI
+	depends on COMMON_CLK
 	default y
 	help
 	  Choose this option if the 28nm DSI PHY 8960 variant is used on the
@@ -107,6 +110,7 @@ config DRM_MSM_DSI_28NM_8960_PHY
 config DRM_MSM_DSI_14NM_PHY
 	bool "Enable DSI 14nm PHY driver in MSM DRM (used by MSM8996/APQ8096)"
 	depends on DRM_MSM_DSI
+	depends on COMMON_CLK
 	default y
 	help
 	  Choose this option if DSI PHY on 8996 is used on the platform.
@@ -114,6 +118,7 @@ config DRM_MSM_DSI_14NM_PHY
 config DRM_MSM_DSI_10NM_PHY
 	bool "Enable DSI 10nm PHY driver in MSM DRM (used by SDM845)"
 	depends on DRM_MSM_DSI
+	depends on COMMON_CLK
 	default y
 	help
 	  Choose this option if DSI PHY on SDM845 is used on the platform.
@@ -121,6 +126,7 @@ config DRM_MSM_DSI_10NM_PHY
 config DRM_MSM_DSI_7NM_PHY
 	bool "Enable DSI 7nm PHY driver in MSM DRM"
 	depends on DRM_MSM_DSI
+	depends on COMMON_CLK
 	default y
 	help
 	  Choose this option if DSI PHY on SM8150/SM8250/SC7280 is used on
-- 
2.25.1


  parent reply	other threads:[~2021-11-10  7:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10  7:09 [PATCH 1/3] drm/msm/hdmi: fix build without CONFIG_COMMON_CLK Jackie Liu
2021-11-10  7:09 ` [PATCH 2/3] drm/msm/dp: displayPort driver need algorithm rational Jackie Liu
2021-11-10  7:09 ` Jackie Liu [this message]
2021-11-10  7:29 ` [PATCH 1/3] drm/msm/hdmi: fix build without CONFIG_COMMON_CLK Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211110070950.3355597-3-liu.yun@linux.dev \
    --to=liu.yun@linux.dev \
    --cc=airlied@linux.ie \
    --cc=architt@codeaurora.org \
    --cc=chandanu@codeaurora.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox