From: Marek Vasut <marex@denx.de>
To: dri-devel@lists.freedesktop.org
Cc: Marek Vasut <marex@denx.de>, Robert Foss <robert.foss@linaro.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Sam Ravnborg <sam@ravnborg.org>,
Maxime Ripard <maxime@cerno.tech>
Subject: [PATCH V2 06/12] drm: bridge: icn6211: Use DSI burst mode without EoT and with LP command mode
Date: Thu, 17 Feb 2022 01:25:24 +0100 [thread overview]
Message-ID: <20220217002530.396563-7-marex@denx.de> (raw)
In-Reply-To: <20220217002530.396563-1-marex@denx.de>
The DSI burst mode is more energy efficient than the DSI sync pulse mode,
make use of the burst mode since the chip supports it as well. Disable the
generation of EoT packet, the chip ignores it, so no point in emitting it.
Enable transmission of data in LP mode, otherwise register read via DSI
does not work with this chip.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: Robert Foss <robert.foss@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
To: dri-devel@lists.freedesktop.org
---
V2: Rebase on next-20220214
---
drivers/gpu/drm/bridge/chipone-icn6211.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
index 7cc1f0d0dcdfd..2040596717139 100644
--- a/drivers/gpu/drm/bridge/chipone-icn6211.c
+++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
@@ -485,7 +485,8 @@ static int chipone_probe(struct mipi_dsi_device *dsi)
dsi->lanes = icn->dsi_lanes;
dsi->format = MIPI_DSI_FMT_RGB888;
- dsi->mode_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE;
+ dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
+ MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET;
ret = mipi_dsi_attach(dsi);
if (ret < 0) {
--
2.34.1
next prev parent reply other threads:[~2022-02-17 0:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 0:25 [PATCH V2 00/12] drm: bridge: icn6211: Fix hard-coded panel settings and add I2C support Marek Vasut
2022-02-17 0:25 ` [PATCH V2 01/12] drm: bridge: icn6211: Fix register layout Marek Vasut
2022-03-02 9:55 ` Maxime Ripard
2022-02-17 0:25 ` [PATCH V2 02/12] drm: bridge: icn6211: Fix HFP_HSW_HBP_HI and HFP_MIN handling Marek Vasut
2022-03-02 9:56 ` Maxime Ripard
2022-02-17 0:25 ` [PATCH V2 03/12] drm: bridge: icn6211: Add HS/VS/DE polarity handling Marek Vasut
2022-03-02 9:59 ` Maxime Ripard
2022-03-02 14:45 ` Marek Vasut
2022-02-17 0:25 ` [PATCH V2 04/12] drm: bridge: icn6211: Add DSI lane count DT property parsing Marek Vasut
2022-03-02 10:01 ` Maxime Ripard
2022-03-02 15:17 ` Marek Vasut
2022-03-03 12:54 ` Maxime Ripard
2022-03-04 0:26 ` Marek Vasut
2022-02-17 0:25 ` [PATCH V2 05/12] drm: bridge: icn6211: Add generic DSI-to-DPI PLL configuration Marek Vasut
2022-03-02 10:02 ` Maxime Ripard
2022-02-17 0:25 ` Marek Vasut [this message]
2022-03-02 10:03 ` [PATCH V2 06/12] drm: bridge: icn6211: Use DSI burst mode without EoT and with LP command mode Maxime Ripard
2022-02-17 0:25 ` [PATCH V2 07/12] drm: bridge: icn6211: Disable DPI color swap Marek Vasut
2022-03-02 10:04 ` Maxime Ripard
2022-02-17 0:25 ` [PATCH V2 08/12] drm: bridge: icn6211: Set SYS_CTRL_1 to value used in examples Marek Vasut
2022-03-02 10:04 ` Maxime Ripard
2022-02-17 0:25 ` [PATCH V2 09/12] drm: bridge: icn6211: Implement atomic_get_input_bus_fmts Marek Vasut
2022-03-02 10:05 ` Maxime Ripard
2022-02-17 0:25 ` [PATCH V2 10/12] drm: bridge: icn6211: Add I2C configuration support Marek Vasut
2022-03-02 10:07 ` Maxime Ripard
2022-02-17 0:25 ` [PATCH V2 11/12] drm: bridge: icn6211: Rework ICN6211_DSI to chipone_writeb() Marek Vasut
2022-03-02 10:08 ` Maxime Ripard
2022-02-17 0:25 ` [PATCH V2 12/12] drm: bridge: icn6211: Read and validate chip IDs before configuration Marek Vasut
2022-03-02 10:08 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217002530.396563-7-marex@denx.de \
--to=marex@denx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=maxime@cerno.tech \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox