[PATCH] accel/ivpu: Remove VPU_CPU_NOC_* register access from NPU6 onward

[PATCH] accel/ivpu: Remove VPU_CPU_NOC_* register access from NPU6 onward

[Maciej Falkowski]

From: Karol Wachowski <karol.wachowski@linux.intel.com>

Quiescing TOP_MMIO in SOC_CPU_NOC as part of boot procedure is no longer
needed starting from 60XX. Remove soc_cpu_drive() call from NPU6 onward.

The VPU_CPU_NOC_QREQN, VPU_CPU_NOC_QACCEPTN, and VPU_CPU_NOC_QDENY
registers are deprecated and non-functional on 60XX. They will be
removed in future generations.

Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
---
 drivers/accel/ivpu/ivpu_hw_ip.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/accel/ivpu/ivpu_hw_ip.c b/drivers/accel/ivpu/ivpu_hw_ip.c
index 9d32273e94ed..06aa1e7dc50b 100644
--- a/drivers/accel/ivpu/ivpu_hw_ip.c
+++ b/drivers/accel/ivpu/ivpu_hw_ip.c
@@ -896,6 +896,9 @@ static int soc_cpu_drive_40xx(struct ivpu_device *vdev, bool enable)
 
 static int soc_cpu_enable(struct ivpu_device *vdev)
 {
+	if (ivpu_hw_ip_gen(vdev) >= IVPU_HW_IP_60XX)
+		return 0;
+
 	return soc_cpu_drive_40xx(vdev, true);
 }
 
-- 
2.43.0

Re: [PATCH] accel/ivpu: Remove VPU_CPU_NOC_* register access from NPU6 onward

[Jeff Hugo]

On 10/21/2025 8:20 AM, Maciej Falkowski wrote:
> From: Karol Wachowski <karol.wachowski@linux.intel.com>
> 
> Quiescing TOP_MMIO in SOC_CPU_NOC as part of boot procedure is no longer
> needed starting from 60XX. Remove soc_cpu_drive() call from NPU6 onward.
> 
> The VPU_CPU_NOC_QREQN, VPU_CPU_NOC_QACCEPTN, and VPU_CPU_NOC_QDENY
> registers are deprecated and non-functional on 60XX. They will be
> removed in future generations.
> 
> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>

Should you just squash this into "[PATCH] accel/ivpu: Add support for 
Nova Lake's NPU"? Feels a bit odd to introduce an issue in that patch, 
and then immediately fix it.

-Jeff

Re: [PATCH] accel/ivpu: Remove VPU_CPU_NOC_* register access from NPU6 onward

[Falkowski, Maciej]

On 10/21/2025 4:55 PM, Jeff Hugo wrote:

> On 10/21/2025 8:20 AM, Maciej Falkowski wrote:
>> From: Karol Wachowski <karol.wachowski@linux.intel.com>
>>
>> Quiescing TOP_MMIO in SOC_CPU_NOC as part of boot procedure is no longer
>> needed starting from 60XX. Remove soc_cpu_drive() call from NPU6 onward.
>>
>> The VPU_CPU_NOC_QREQN, VPU_CPU_NOC_QACCEPTN, and VPU_CPU_NOC_QDENY
>> registers are deprecated and non-functional on 60XX. They will be
>> removed in future generations.
>>
>> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
>> Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
>
> Should you just squash this into "[PATCH] accel/ivpu: Add support for 
> Nova Lake's NPU"? Feels a bit odd to introduce an issue in that patch, 
> and then immediately fix it.
It wasn't exactly introducing an issue but sure squashing the two 
commits into one will simplify things.

Thanks,
Maciej

>
> -Jeff