Re: [PATCH 09/16] ASoC: dt-bindings: add OpenPandora Sound Card

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `$id` and `$schema` fields in the YAML schema contain invalid URIs, breaking schema validation.
- [Low] The `status` property is explicitly and unnecessarily defined in the binding schema.
--

--- Patch [9]: [PATCH 09/16] ASoC: dt-bindings: add OpenPandora Sound Card ---
commit 94d05b63d0a0b038d3a5355e6b58cc3b78b60eeb
Author: H. Nikolaus Schaller <hns@goldelico.com>

ASoC: dt-bindings: add OpenPandora Sound Card

The OpenPandora audio subsystem describes the routing links between the
OMAP3 McBSP interface, the external PCM1773 DAC, and the TWL4030 audio
codec, alongside amplifiers and power supplies.

> diff --git a/Documentation/devicetree/bindings/sound/openpandora,omap3pandora-sound.yaml b/Documentation/devicetree/bindings/sound/openpandora,omap3pandora-sound.yaml
> new file mode 100644
> index 0000000000000..d3c747e5c58d6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/openpandora,omap3pandora-sound.yaml
> @@ -0,0 +1,94 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org
> +$schema: http://devicetree.org

[Severity: Medium]
Is the $id field missing the full path? As per the device tree binding
guidelines, an incorrect $id field breaks the schema cross-reference system
and causes dt_binding_check to silently skip validation. It typically needs
to begin with http://devicetree.org/schemas/ and exactly match the file path.

Additionally, shouldn't $schema be set to the standard meta-schema
(http://devicetree.org/meta-schemas/core.yaml#) instead of the base URL?

> +
> +title: OpenPandora OMAP3 Audio Complex
> +
> +maintainers:
> + - H. Nikolaus Schaller <hns@goldelico.com>
> +
> +description:
> + The OpenPandora audio subsystem describes the routing links between the
> + OMAP3 McBSP interface, the external PCM1773 DAC, and the TWL4030 audio codec,
> + alongside amplifiers and power supplies.
> +
> +properties:
> + compatible:
> +   const: openpandora,omap3pandora-sound
> +
> + status: true

[Severity: Low]
This isn't a bug, but is it necessary to explicitly define the status
property here? Since status is a core standard device tree property, it is
implicitly handled by the core dt-schema. Redefining it here without
constraints is redundant.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1783749722.git.hns@goldelico.com?part=9