[PATCH v2 00/12] drm/bridge: Kconfig: cleanup DRM_PANEL usage

[PATCH v2 00/12] drm/bridge: Kconfig: cleanup DRM_PANEL usage

[Luca Ceresoli]

As a cleanup in preparation for making every drm_panel create a
panel_bridge, remove unnecessary or wrong usage of 'depends on DRM_PANEL'
and 'select DRM_PANEL' from drivers/gpu/drm/bridge/Kconfig.

== Grand plan

This is part of the work to support hotplug of DRM bridges. The grand plan
was discussed in [0].

Here's the work breakdown (➜ marks the current series):

 1. ➜ add refcounting to DRM bridges struct drm_bridge,
      based on devm_drm_bridge_alloc()
    A. ✔ add new alloc API and refcounting (v6.16)
    B. ✔ convert all bridge drivers to new API (v6.17)
    C. ✔ kunit tests (v6.17)
    D. ✔ add get/put to drm_bridge_add/remove() + attach/detach()
         and warn on old allocation pattern (v6.17)
    E. ➜ add get/put on drm_bridge accessors
       1. ✔ drm_bridge_chain_get_first_bridge(), add cleanup action (v6.18)
       2. ✔ drm_bridge_get_prev_bridge() (v6.18)
       3. ✔ drm_bridge_get_next_bridge() (v6.19)
       4. ✔ drm_for_each_bridge_in_chain() (v6.19)
       5. ✔ drm_bridge_connector_init (v6.19)
       6. ✔ protect encoder bridge chain with a mutex (v7.2)
       7. ✔ of_drm_find_bridge
          a. ✔ add of_drm_get_bridge() (v7.0),
               convert basic direct users (v7.0-v7.1)
          b. ✔ convert direct of_drm_get_bridge() users, part 2 (v7.0)
          c. ✔ convert direct of_drm_get_bridge() users, part 3 (v7.0)
          d. ✔ convert direct of_drm_get_bridge() users, part 4 (v7.1-v7.2)
          e. ✔ bridge-only drm_of_find_panel_or_bridge() users (v7.2)
       8. ➜ panel_bridge lifetime
          a. ➜ cleanup DRM_PANEL in bridge drivers
	  b.   add a panel_bridge to every panel
       9. ✔ enforce drm_bridge_add before drm_bridge_attach (v6.19)
    F. ✔ debugfs improvements
       1. ✔ add top-level 'bridges' file (v6.16)
       2. ✔ show refcount and list lingering bridges (v6.19)
 2. ✔ handle gracefully atomic updates during bridge removal
    A. ✔ Add drm_bridge_enter/exit() to protect device resources (v7.0)
    B. ✔ Add drm_bridge_clear_and_put() (v7.1)
 3. … DSI host-device driver interaction
 4. ✔ removing the need for the "always-disconnected" connector
 5. ✔ Migrate i.MX LCDIF driver to bridge-connector (v7.2)
 6. … DRM bridge hotplug
    A. … Bridge hotplug management in the DRM core
       1. ✔ bridge-connector: attach encoder to the connector (v7.2)
       2. … drm bridge hotplug
    B.   Device tree description

[0] https://lore.kernel.org/lkml/20250206-hotplug-drm-bridge-v6-0-9d6f2c9c3058@bootlin.com/#t

Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Changes in v2:
- Added maintainers and recent authors to per-patch Cc list (these are not
  added automatically by get-maintainers because the patches touch only the
  Kconfig file)
- Added review trailer
- No changes to commit messages and patch content
- Link to v1: https://patch.msgid.link/20260812-drm-bridge-drm_panel-cleanup-v1-0-0d86734e908a@bootlin.com

---
Luca Ceresoli (12):
      drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: don't select unused DRM_PANEL
      drm/bridge: tc358764: don't select unused DRM_PANEL
      drm/bridge: ti-dlpc3433: don't depend on DRM_PANEL
      drm/bridge: ti-sn65dsi86: don't select unused DRM_PANEL
      drm/bridge: ti-sn65dsi83: select DRM_PANEL_BRIDGE
      drm/bridge: nxp-ptn3460: select DRM_PANEL_BRIDGE
      drm/bridge: parade-ps8622: select DRM_PANEL_BRIDGE
      drm/bridge: parade-ps8640: select DRM_PANEL_BRIDGE
      drm/bridge: tc358775: select DRM_PANEL_BRIDGE
      drm/bridge: tc358767: select DRM_PANEL_BRIDGE
      drm/bridge: tc358768: select DRM_PANEL_BRIDGE
      drm/bridge: ssd2825: select DRM_PANEL_BRIDGE

 drivers/gpu/drm/bridge/Kconfig | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)
---
base-commit: e935b7289ea925084ab342a141b153cc3e875391
change-id: 20260812-drm-bridge-drm_panel-cleanup-09ed5cc10948

Best regards,
--  
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[PATCH v2 01/12] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: don't select unused DRM_PANEL

[Luca Ceresoli]

This driver does not use the drm_panel APIs at all, so no need to select
DRM_PANEL.

Cc: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Martyn Welch <martyn.welch@collabora.co.uk>
Cc: Andy Yan <andyshrk@163.com>
Reviewed-by: Ian Ray <ian.ray@gehealthcare.com>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/bridge/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 4a57d49b4c6d..a999e57d0cc1 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -225,7 +225,6 @@ config DRM_MEGACHIPS_STDPXXXX_GE_B850V3_FW
 	tristate "MegaChips stdp4028-ge-b850v3-fw and stdp2690-ge-b850v3-fw"
 	depends on OF
 	select DRM_KMS_HELPER
-	select DRM_PANEL
 	help
 	  This is a driver for the display bridges of
 	  GE B850v3 that convert dual channel LVDS

-- 
2.55.0

[PATCH v2 02/12] drm/bridge: tc358764: don't select unused DRM_PANEL

[Luca Ceresoli]

This driver does not use the drm_panel APIs at all, so no need to select
DRM_PANEL.

Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/bridge/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index a999e57d0cc1..958b4f687d4d 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -388,7 +388,6 @@ config DRM_TOSHIBA_TC358764
 	depends on OF
 	select DRM_MIPI_DSI
 	select DRM_KMS_HELPER
-	select DRM_PANEL
 	help
 	  Toshiba TC358764 DSI/LVDS bridge driver.
 

-- 
2.55.0

[PATCH v2 03/12] drm/bridge: ti-dlpc3433: don't depend on DRM_PANEL

[Luca Ceresoli]

This driver does not use the drm_panel APIs at all, so no need to select
DRM_PANEL.

Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Christopher Vollo <chris@renewoutreach.org>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/bridge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 958b4f687d4d..043596801a65 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -428,7 +428,7 @@ config DRM_TOSHIBA_TC358775
 
 config DRM_TI_DLPC3433
 	tristate "TI DLPC3433 Display controller"
-	depends on DRM && DRM_PANEL
+	depends on DRM
 	depends on OF
 	select DRM_MIPI_DSI
 	help

-- 
2.55.0

Re: [PATCH v2 03/12] drm/bridge: ti-dlpc3433: don't depend on DRM_PANEL

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The DSI device registered with `mipi_dsi_device_register_full()` is never unregistered, causing a memory and device node leak that prevents driver reload.
--

--- Patch [3]: [PATCH v2 03/12] drm/bridge: ti-dlpc3433: don't depend on DRM_PANEL ---
commit 1c4393105a1871917fd54292e2edbfa8634d5ce0
Author: Luca Ceresoli <luca.ceresoli@bootlin.com>

drm/bridge: ti-dlpc3433: don't depend on DRM_PANEL

This driver does not use the drm_panel APIs at all, so no need to select
DRM_PANEL.

> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 958b4f687d4dd..043596801a65b 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -428,7 +428,7 @@ config DRM_TOSHIBA_TC358775
>  
>  config DRM_TI_DLPC3433
>  	tristate "TI DLPC3433 Display controller"
> -	depends on DRM && DRM_PANEL
> +	depends on DRM

[Severity: High]
This is a pre-existing issue, but I noticed a device node leak in the
driver itself.

In dlpc_host_attach(), the DSI device is registered manually:

drivers/gpu/drm/bridge/ti-dlpc3433.c:dlpc_host_attach()
    ...
    dlpc->dsi = mipi_dsi_device_register_full(host, &info);
    ...

However, the remove callback fails to unregister it:

drivers/gpu/drm/bridge/ti-dlpc3433.c:dlpc3433_remove()
static void dlpc3433_remove(struct i2c_client *client)
{
	struct dlpc *dlpc = i2c_get_clientdata(client);

	drm_bridge_remove(&dlpc->bridge);
	of_node_put(dlpc->host_node);
}

Should there be a call to mipi_dsi_device_unregister(dlpc->dsi) here to
prevent leaking the device node unconditionally upon unbind? Alternatively,
could this be migrated to devm_mipi_dsi_device_register_full() so it is
managed by devres?

>  	depends on OF
>  	select DRM_MIPI_DSI
>  	help

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825-drm-bridge-drm_panel-cleanup-v2-0-c6c88ba7ffd2@bootlin.com?part=3

[PATCH v2 04/12] drm/bridge: ti-sn65dsi86: don't select unused DRM_PANEL

[Luca Ceresoli]

This driver does not use the drm_panel APIs at all, so no need to select
DRM_PANEL.

Cc: Douglas Anderson <dianders@chromium.org>
Cc: Sandeep Panda <spanda@codeaurora.org>
Cc: Franz Schnyder <franz.schnyder@toradex.com>
Cc: John Ripple <john.ripple@keysight.com>
Cc: Michael Walle <mwalle@kernel.org>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/bridge/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 043596801a65..d46aa2eb01b5 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -474,7 +474,6 @@ config DRM_TI_SN65DSI86
 	select DRM_BRIDGE_CONNECTOR
 	select DRM_KMS_HELPER
 	select REGMAP_I2C
-	select DRM_PANEL
 	select DRM_MIPI_DSI
 	select AUXILIARY_BUS
 	select DRM_DISPLAY_DP_AUX_BUS

-- 
2.55.0

Re: [PATCH v2 04/12] drm/bridge: ti-sn65dsi86: don't select unused DRM_PANEL

[Doug Anderson]

Hi,

On Tue, Aug 25, 2026 at 3:11 AM Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
>
> This driver does not use the drm_panel APIs at all, so no need to select
> DRM_PANEL.
>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Sandeep Panda <spanda@codeaurora.org>
> Cc: Franz Schnyder <franz.schnyder@toradex.com>
> Cc: John Ripple <john.ripple@keysight.com>
> Cc: Michael Walle <mwalle@kernel.org>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
>  drivers/gpu/drm/bridge/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 043596801a65..d46aa2eb01b5 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -474,7 +474,6 @@ config DRM_TI_SN65DSI86
>         select DRM_BRIDGE_CONNECTOR
>         select DRM_KMS_HELPER
>         select REGMAP_I2C
> -       select DRM_PANEL
>         select DRM_MIPI_DSI
>         select AUXILIARY_BUS
>         select DRM_DISPLAY_DP_AUX_BUS

Looks right to me. Ages ago it used panel APIs directly, but not today.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

I assume you have a plan for landing the series. If you want me to
land this patch on its own to drm-misc-next, please yell.

[PATCH v2 05/12] drm/bridge: ti-sn65dsi83: select DRM_PANEL_BRIDGE

[Luca Ceresoli]

This driver uses the drm_panel_bridge API and not the drm_panel API so it
should select DRM_PANEL_BRIDGE and not DRM_PANEL.

Cc: Marek Vasut <marex@denx.de>
Cc: Sudarshan Shetty <tessolveupstream@gmail.com>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Herve Codina <herve.codina@bootlin.com>
Cc: Esben Haabendal <esben@geanix.com>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/bridge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index d46aa2eb01b5..03f52dcbba6f 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -461,7 +461,7 @@ config DRM_TI_SN65DSI83
 	depends on OF
 	select DRM_KMS_HELPER
 	select REGMAP_I2C
-	select DRM_PANEL
+	select DRM_PANEL_BRIDGE
 	select DRM_MIPI_DSI
 	help
 	  Texas Instruments SN65DSI83 and SN65DSI84 DSI to LVDS Bridge driver

-- 
2.55.0

Re: [PATCH v2 05/12] drm/bridge: ti-sn65dsi83: select DRM_PANEL_BRIDGE

[Herve Codina]

Hi Luca,

On Tue, 25 Aug 2026 12:09:38 +0200
Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:

> This driver uses the drm_panel_bridge API and not the drm_panel API so it
> should select DRM_PANEL_BRIDGE and not DRM_PANEL.
> 
> Cc: Marek Vasut <marex@denx.de>
> Cc: Sudarshan Shetty <tessolveupstream@gmail.com>
> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
> Cc: Herve Codina <herve.codina@bootlin.com>
> Cc: Esben Haabendal <esben@geanix.com>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
>  drivers/gpu/drm/bridge/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index d46aa2eb01b5..03f52dcbba6f 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -461,7 +461,7 @@ config DRM_TI_SN65DSI83
>  	depends on OF
>  	select DRM_KMS_HELPER
>  	select REGMAP_I2C
> -	select DRM_PANEL
> +	select DRM_PANEL_BRIDGE
>  	select DRM_MIPI_DSI
>  	help
>  	  Texas Instruments SN65DSI83 and SN65DSI84 DSI to LVDS Bridge driver
> 

Makes sense on my side.

Reviewed-by: Herve Codina <herve.codina@bootlin.com>

Best regards,
Hervé

Re: [PATCH v2 05/12] drm/bridge: ti-sn65dsi83: select DRM_PANEL_BRIDGE

[Esben Haabendal]

"Luca Ceresoli" <luca.ceresoli@bootlin.com> writes:

> This driver uses the drm_panel_bridge API and not the drm_panel API so it
> should select DRM_PANEL_BRIDGE and not DRM_PANEL.
>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Sudarshan Shetty <tessolveupstream@gmail.com>
> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
> Cc: Herve Codina <herve.codina@bootlin.com>
> Cc: Esben Haabendal <esben@geanix.com>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
>  drivers/gpu/drm/bridge/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index d46aa2eb01b5..03f52dcbba6f 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -461,7 +461,7 @@ config DRM_TI_SN65DSI83
>  	depends on OF
>  	select DRM_KMS_HELPER
>  	select REGMAP_I2C
> -	select DRM_PANEL
> +	select DRM_PANEL_BRIDGE
>  	select DRM_MIPI_DSI
>  	help
>  	  Texas Instruments SN65DSI83 and SN65DSI84 DSI to LVDS Bridge driver
>
> --
> 2.55.0

Acked-by: Esben Haabendal <esben@geanix.com>

[PATCH v2 06/12] drm/bridge: nxp-ptn3460: select DRM_PANEL_BRIDGE

[Luca Ceresoli]

This driver uses the drm_panel_bridge API and not the drm_panel API so it
should select DRM_PANEL_BRIDGE and not DRM_PANEL.

Cc: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/bridge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 03f52dcbba6f..e59b6689ced3 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -259,7 +259,7 @@ config DRM_NXP_PTN3460
 	tristate "NXP PTN3460 DP/LVDS bridge"
 	depends on OF
 	select DRM_KMS_HELPER
-	select DRM_PANEL
+	select DRM_PANEL_BRIDGE
 	help
 	  NXP PTN3460 eDP-LVDS bridge chip driver.
 

-- 
2.55.0

[PATCH v2 07/12] drm/bridge: parade-ps8622: select DRM_PANEL_BRIDGE

[Luca Ceresoli]

This driver uses the drm_panel_bridge API and not the drm_panel API so it
should select DRM_PANEL_BRIDGE and not DRM_PANEL.

Cc: Vincent Palatin <vpalatin@chromium.org>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/bridge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index e59b6689ced3..8bb5612a0ff5 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -276,7 +276,7 @@ config DRM_OF_DISPLAY_MODE_BRIDGE
 config DRM_PARADE_PS8622
 	tristate "Parade eDP/LVDS bridge"
 	depends on OF
-	select DRM_PANEL
+	select DRM_PANEL_BRIDGE
 	select DRM_KMS_HELPER
 	select BACKLIGHT_CLASS_DEVICE
 	help

-- 
2.55.0

[PATCH v2 08/12] drm/bridge: parade-ps8640: select DRM_PANEL_BRIDGE

[Luca Ceresoli]

This driver uses the drm_panel_bridge API and not the drm_panel API so it
should select DRM_PANEL_BRIDGE and not DRM_PANEL.

Cc: Douglas Anderson <dianders@chromium.org>
Cc: Jitao Shi <jitao.shi@mediatek.com>
Cc: CK Hu <ck.hu@mediatek.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Pin-yen Lin <treapking@chromium.org>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/bridge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 8bb5612a0ff5..0f9ca869237b 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -290,7 +290,7 @@ config DRM_PARADE_PS8640
 	select DRM_DISPLAY_DP_AUX_BUS
 	select DRM_KMS_HELPER
 	select DRM_MIPI_DSI
-	select DRM_PANEL
+	select DRM_PANEL_BRIDGE
 	help
 	  Choose this option if you have PS8640 for display
 	  The PS8640 is a high-performance and low-power

-- 
2.55.0

Re: [PATCH v2 08/12] drm/bridge: parade-ps8640: select DRM_PANEL_BRIDGE

[Doug Anderson]

Hi,

On Tue, Aug 25, 2026 at 3:11 AM Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
>
> This driver uses the drm_panel_bridge API and not the drm_panel API so it
> should select DRM_PANEL_BRIDGE and not DRM_PANEL.

Which exact "drm_panel_bridge" API does it use? I don't see any...
Certainly it's highly likely that the next bridge in the chain is a
panel, but there are no API calls that I see. Maybe the scripts got
confused because the variable name didn't get updated in commit
5486eac81004 ("drm/bridge: parade-ps8640: switch to
devm_drm_of_get_bridge") ?

-Doug

[PATCH v2 09/12] drm/bridge: tc358775: select DRM_PANEL_BRIDGE

[Luca Ceresoli]

This driver uses the drm_panel_bridge API and not the drm_panel API so it
should select DRM_PANEL_BRIDGE and not DRM_PANEL.

Cc: Tony Lindgren <tony@atomide.com>
Cc: Michael Walle <mwalle@kernel.org>
Cc: Vinay Simha BN <simhavcs@gmail.com>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/bridge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 0f9ca869237b..7874d3b1e760 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -421,7 +421,7 @@ config DRM_TOSHIBA_TC358775
 	select DRM_DISPLAY_HELPER
 	select DRM_KMS_HELPER
 	select REGMAP_I2C
-	select DRM_PANEL
+	select DRM_PANEL_BRIDGE
 	select DRM_MIPI_DSI
 	help
 	  Toshiba TC358775 DSI/LVDS bridge chip driver.

-- 
2.55.0

[PATCH v2 10/12] drm/bridge: tc358767: select DRM_PANEL_BRIDGE

[Luca Ceresoli]

This driver uses a mixture of drm_panel and drm_panel_bridge APIs, but the
Kconfig symbol only selects DRM_PANEL.

Select DRM_PANEL_BRIDGE instead, which in turn depends on DRM_PANEL.

Cc: Maoyi Xie <maoyixie.tju@gmail.com>
Cc: Andy Yan <andy.yan@rock-chips.com>
Cc: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/bridge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 7874d3b1e760..8eaaa3282062 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -399,7 +399,7 @@ config DRM_TOSHIBA_TC358767
 	select DRM_KMS_HELPER
 	select REGMAP_I2C
 	select DRM_MIPI_DSI
-	select DRM_PANEL
+	select DRM_PANEL_BRIDGE
 	help
 	  Toshiba TC358767 eDP bridge chip driver.
 

-- 
2.55.0

Re: [PATCH v2 10/12] drm/bridge: tc358767: select DRM_PANEL_BRIDGE

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete Kconfig cleanup in patch series: DRM_TOSHIBA_TC358764 uses drm_panel_bridge APIs but does not select DRM_PANEL_BRIDGE.
--

--- Patch [10]: [PATCH v2 10/12] drm/bridge: tc358767: select DRM_PANEL_BRIDGE ---
commit 0a2f8ec4febb1e1d377dd7d92fdc0b82006defba
Author: Luca Ceresoli <luca.ceresoli@bootlin.com>

drm/bridge: tc358767: select DRM_PANEL_BRIDGE

This driver uses a mixture of drm_panel and drm_panel_bridge APIs, but the
Kconfig symbol only selects DRM_PANEL. Select DRM_PANEL_BRIDGE instead,
which in turn depends on DRM_PANEL.

> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 7874d3b1e7608..8eaaa3282062a 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -399,7 +399,7 @@ config DRM_TOSHIBA_TC358767
>  	select DRM_KMS_HELPER
>  	select REGMAP_I2C
>  	select DRM_MIPI_DSI
> -	select DRM_PANEL
> +	select DRM_PANEL_BRIDGE

[Severity: Low]
Since you are updating bridge drivers in this series to select
DRM_PANEL_BRIDGE, should DRM_TOSHIBA_TC358764 also be updated?

In drivers/gpu/drm/bridge/tc358764.c:tc358764_probe(), the driver uses
devm_drm_of_get_bridge():

	ctx->next_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
	if (IS_ERR(ctx->next_bridge))

This API call relies on CONFIG_DRM_PANEL_BRIDGE being enabled, but
config DRM_TOSHIBA_TC358764 doesn't select DRM_PANEL_BRIDGE. If the default
for CONFIG_DRM_PANEL_BRIDGE ever changes, could this cause
devm_drm_of_get_bridge() to silently return -ENODEV and fail probing?

>  	help
>  	  Toshiba TC358767 eDP bridge chip driver.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825-drm-bridge-drm_panel-cleanup-v2-0-c6c88ba7ffd2@bootlin.com?part=10

[PATCH v2 11/12] drm/bridge: tc358768: select DRM_PANEL_BRIDGE

[Luca Ceresoli]

This driver uses a mixture of drm_panel and drm_panel_bridge APIs, but the
Kconfig symbol only selects DRM_PANEL.

Select DRM_PANEL_BRIDGE instead, which in turn depends on DRM_PANEL.

Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/bridge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 8eaaa3282062..afcc5cce88cb 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -408,7 +408,7 @@ config DRM_TOSHIBA_TC358768
 	depends on OF
 	select DRM_KMS_HELPER
 	select REGMAP_I2C
-	select DRM_PANEL
+	select DRM_PANEL_BRIDGE
 	select DRM_MIPI_DSI
 	select VIDEOMODE_HELPERS
 	help

-- 
2.55.0

[PATCH v2 12/12] drm/bridge: ssd2825: select DRM_PANEL_BRIDGE

[Luca Ceresoli]

This driver uses a mixture of drm_panel and drm_panel_bridge APIs, but the
Kconfig symbol only selects DRM_PANEL.

Select DRM_PANEL_BRIDGE instead, which in turn depends on DRM_PANEL.

Cc: Svyatoslav Ryhel <clamor95@gmail.com>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/bridge/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index afcc5cce88cb..02c41ec2587f 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -350,7 +350,7 @@ config DRM_SOLOMON_SSD2825
 	depends on SPI_MASTER && OF
 	select DRM_MIPI_DSI
 	select DRM_KMS_HELPER
-	select DRM_PANEL
+	select DRM_PANEL_BRIDGE
 	help
 	  Say Y here if you want support for the Solomon SSD2825 RGB/DSI
 	  SPI bridge driver.

-- 
2.55.0