From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mark Brown <broonie@sirena.org.uk>, David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/rcar-du: Add missing dependency on CMA
Date: Wed, 10 Jul 2013 13:35:31 +0200 [thread overview]
Message-ID: <2033202.g329uvd6Un@avalon> (raw)
In-Reply-To: <20130710110724.GD24508@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 925 bytes --]
On Wednesday 10 July 2013 12:07:24 Mark Brown wrote:
> On Wed, Jul 10, 2013 at 12:54:40PM +0200, Laurent Pinchart wrote:
> > On Wednesday 10 July 2013 11:52:14 Mark Brown wrote:
> > > config DRM_RCAR_DU
> > >
> > > tristate "DRM Support for R-Car Display Unit"
> > >
> > > - depends on DRM && ARM
> > > + depends on DRM && ARM && CMA
> > >
> > > select DRM_KMS_HELPER
> > > select DRM_KMS_CMA_HELPER
> > > select DRM_GEM_CMA_HELPER
> >
> > Shouldn't we instead make DRM_GEM_CMA_HELPER depend on CMA ?
>
> Sadly select doesn't do the right thing with dependencies - it just ignores
> them.
OK, my bad.
On the other hand, thinking a bit more about this, the DU driver doesn't use
the CMA API directly, as there's no CMA API exposed to drivers :-) I've
successfully built the driver with CONFIG_CMA disabled. Could you please share
the .config that resulted in a link error ?
--
Regards,
Laurent Pinchart
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2013-07-10 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 10:52 [PATCH] drm/rcar-du: Add missing dependency on CMA Mark Brown
2013-07-10 10:54 ` Laurent Pinchart
2013-07-10 11:07 ` Mark Brown
2013-07-10 11:35 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2033202.g329uvd6Un@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=broonie@sirena.org.uk \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox