From: Mark Brown <broonie@sirena.org.uk>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/rcar-du: Add missing dependency on CMA
Date: Wed, 10 Jul 2013 12:07:24 +0100 [thread overview]
Message-ID: <20130710110724.GD24508@sirena.org.uk> (raw)
In-Reply-To: <9815009.SJ9cp8Rvrj@avalon>
[-- Attachment #1.1: Type: text/plain, Size: 500 bytes --]
On Wed, Jul 10, 2013 at 12:54:40PM +0200, Laurent Pinchart wrote:
> On Wednesday 10 July 2013 11:52:14 Mark Brown wrote:
> > config DRM_RCAR_DU
> > tristate "DRM Support for R-Car Display Unit"
> > - depends on DRM && ARM
> > + depends on DRM && ARM && CMA
> > select DRM_KMS_HELPER
> > select DRM_KMS_CMA_HELPER
> > select DRM_GEM_CMA_HELPER
> Shouldn't we instead make DRM_GEM_CMA_HELPER depend on CMA ?
Sadly select doesn't do the right thing with dependencies - it just
ignores them.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-07-10 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 10:52 [PATCH] drm/rcar-du: Add missing dependency on CMA Mark Brown
2013-07-10 10:54 ` Laurent Pinchart
2013-07-10 11:07 ` Mark Brown [this message]
2013-07-10 11:35 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130710110724.GD24508@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox