From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mark Brown <broonie@kernel.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org, Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] drm/rcar-du: Add missing dependency on CMA
Date: Wed, 10 Jul 2013 12:54:40 +0200 [thread overview]
Message-ID: <9815009.SJ9cp8Rvrj@avalon> (raw)
In-Reply-To: <1373453534-6425-1-git-send-email-broonie@kernel.org>
Hi Mark,
Thanks for the patch.
On Wednesday 10 July 2013 11:52:14 Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The driver uses CMA APIs so won't link if CMA is not being built.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/gpu/drm/rcar-du/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/Kconfig
> b/drivers/gpu/drm/rcar-du/Kconfig index 72887df..e75575a 100644
> --- a/drivers/gpu/drm/rcar-du/Kconfig
> +++ b/drivers/gpu/drm/rcar-du/Kconfig
> @@ -1,6 +1,6 @@
> config DRM_RCAR_DU
> tristate "DRM Support for R-Car Display Unit"
> - depends on DRM && ARM
> + depends on DRM && ARM && CMA
> select DRM_KMS_HELPER
> select DRM_KMS_CMA_HELPER
> select DRM_GEM_CMA_HELPER
Shouldn't we instead make DRM_GEM_CMA_HELPER depend on CMA ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-07-10 10:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 10:52 [PATCH] drm/rcar-du: Add missing dependency on CMA Mark Brown
2013-07-10 10:54 ` Laurent Pinchart [this message]
2013-07-10 11:07 ` Mark Brown
2013-07-10 11:35 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9815009.SJ9cp8Rvrj@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox