From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jyri Sarha <jsarha@ti.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/6] drm/omap: add new connector types
Date: Mon, 08 May 2017 19:21:43 +0300 [thread overview]
Message-ID: <2606120.kb4OPh3bny@avalon> (raw)
In-Reply-To: <fa94ccc1-d419-30f5-7954-68ccb5cb4c34@ti.com>
Hi Tomi,
On Monday 08 May 2017 17:35:50 Tomi Valkeinen wrote:
> On 08/05/17 17:21, Laurent Pinchart wrote:
> > On Thursday 27 Apr 2017 13:27:49 Tomi Valkeinen wrote:
> >> We have been using DRM_MODE_CONNECTOR_Unknown for many of our outputs
> >> because there has not been a proper connector type for them.
> >>
> >> We now have connector type for DPI so let's take it into use. At the
> >> same time, add better connector types for the remaining outputs too.
> >>
> >> This patch sets the following outputs to use the following connector
> >> types:
> >>
> >> DPI -> DPI
> >> DBI -> DPI (MIPI DBI is very similar to DPI at the bus level)
> >
> > This looks OK to me.
> >
> >> SDI -> LVDS (SDI is a type of LVDS)
> >
> > If we're talking about this
> > https://en.wikipedia.org/wiki/Serial_digital_interface SDI, it's not a
> > type of LVDS at all. DRM_MODE_CONNECTOR_LVDS is interpreted as meaning
> > that an LVDS display panel is attached to the device, and is likely not
> > removable. I don't think it's a good match for SDI. We might need a new
> > connector type.
>
> No, it's not that. It's Serial display interface. I think it's
> FPDLink/FlatLink.
Ah that makes more sense. Could you maybe mention that in the commit message ?
> >> VENC -> SVIDEO (it could also be composite, but we don't have that
> >> information here, so svideo should be quite good match)
> >
> > Do we have the information anywhere ?
>
> Yes, in the dts. At some point we should use that data, but I didn't
> want to start digging the encoder/connector properties here.
So we don't need to program the hardware differently for S-Video and Composite
? OK, in that case, with a few words about SDI in the commit message,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-05-08 16:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 10:27 [PATCH 0/6] drm/omap: misc changes Tomi Valkeinen
2017-04-27 10:27 ` [PATCH 1/6] drm/omap: add new connector types Tomi Valkeinen
2017-05-08 14:21 ` Laurent Pinchart
2017-05-08 14:35 ` Tomi Valkeinen
2017-05-08 16:21 ` Laurent Pinchart [this message]
2017-05-09 6:57 ` Tomi Valkeinen
2017-05-09 7:16 ` [PATCH 1/6 v2] " Tomi Valkeinen
2017-05-09 7:36 ` Jyri Sarha
2017-05-09 7:41 ` Tomi Valkeinen
2017-05-09 22:35 ` Laurent Pinchart
2017-05-10 6:59 ` Tomi Valkeinen
2017-04-27 10:27 ` [PATCH 2/6] drm/omap: remove unused ovl_enabled() Tomi Valkeinen
2017-05-08 14:23 ` Laurent Pinchart
2017-04-27 10:27 ` [PATCH 3/6] drm/omap: remove ovl_set_channel_out Tomi Valkeinen
2017-05-08 14:26 ` Laurent Pinchart
2017-05-09 7:12 ` Tomi Valkeinen
2017-04-27 10:27 ` [PATCH 4/6] drm/omap: remove read_irqenable() Tomi Valkeinen
2017-05-08 14:28 ` Laurent Pinchart
2017-04-27 10:27 ` [PATCH 5/6] drm/omap: 64bit compile fixes Tomi Valkeinen
2017-05-08 14:29 ` Laurent Pinchart
2017-04-27 10:27 ` [PATCH 6/6] drm/omap: define compat_ioctl Tomi Valkeinen
2017-05-08 14:32 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2606120.kb4OPh3bny@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox