Re: [PATCH 2/6] drm/omap: remove unused ovl_enabled()

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Tomi,

Thank you for the patch.

On Thursday 27 Apr 2017 13:27:50 Tomi Valkeinen wrote:
> ovl_enabled() is not used anywhere, so remove it.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/dss/dispc.c   | 6 ------
>  drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 -
>  2 files changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c
> b/drivers/gpu/drm/omapdrm/dss/dispc.c index 5ac0145fbae6..9fba92973d0e
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dispc.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c
> @@ -2935,11 +2935,6 @@ static int dispc_ovl_enable(enum omap_plane_id plane,
> bool enable) return 0;
>  }
> 
> -static bool dispc_ovl_enabled(enum omap_plane_id plane)
> -{
> -	return REG_GET(DISPC_OVL_ATTRIBUTES(plane), 0, 0);
> -}
> -
>  static enum omap_dss_output_id dispc_mgr_get_supported_outputs(enum
> omap_channel channel) {
>  	return dss_feat_get_supported_outputs(channel);
> @@ -4377,7 +4372,6 @@ static const struct dispc_ops dispc_ops = {
>  	.mgr_set_gamma = dispc_mgr_set_gamma,
> 
>  	.ovl_enable = dispc_ovl_enable,
> -	.ovl_enabled = dispc_ovl_enabled,
>  	.ovl_set_channel_out = dispc_ovl_set_channel_out,
>  	.ovl_setup = dispc_ovl_setup,
>  	.ovl_get_color_modes = dispc_ovl_get_color_modes,
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> b/drivers/gpu/drm/omapdrm/dss/omapdss.h index b19dae1fd6c5..d9ad33df0455
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -913,7 +913,6 @@ struct dispc_ops {
>  		unsigned int length);
> 
>  	int (*ovl_enable)(enum omap_plane_id plane, bool enable);
> -	bool (*ovl_enabled)(enum omap_plane_id plane);
>  	void (*ovl_set_channel_out)(enum omap_plane_id plane,
>  			enum omap_channel channel);
>  	int (*ovl_setup)(enum omap_plane_id plane,

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel