Re: [PATCH 30/41] drm/omapdrm: Use the drm_driver.dumb_destroy default

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: narmstrong@baylibre.com, liviu.dudau@arm.com,
	dri-devel@lists.freedesktop.org, linux@armlinux.org.uk,
	thierry.reding@gmail.com, kraxel@redhat.com,
	daniel.vetter@intel.com, marex@denx.de,
	boris.brezillon@free-electrons.com, abrodkin@synopsys.com,
	z.liuxinliang@hisilicon.com, kong.kongxinwei@hisilicon.com,
	tomi.valkeinen@ti.com, bskeggs@redhat.com, airlied@redhat.com,
	puck.chen@hisilicon.com, zourongrong@gmail.com, jsarha@ti.com,
	vincent.abriou@st.com, alison.wang@freescale.com,
	sw0312.kim@samsung.com, philippe.cornu@st.com,
	yannick.fertre@st.com, kyungmin.park@samsung.com,
	alexander.deucher@amd.com, maxime.ripard@free-electrons.com,
	shawnguo@kernel.org, christian.koenig@amd.com
Subject: Re: [PATCH 30/41] drm/omapdrm: Use the drm_driver.dumb_destroy default
Date: Tue, 25 Jul 2017 01:51:11 +0300	[thread overview]
Message-ID: <2613071.47pcSk9iAt@avalon> (raw)
In-Reply-To: <1500837417-40580-31-git-send-email-noralf@tronnes.org>

Hi Noralf,

Thank you for the patch.

On Sunday 23 Jul 2017 21:16:46 Noralf Trønnes wrote:
> drm_gem_dumb_destroy() is the drm_driver.dumb_destroy default,
> so no need to set it.
> 
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_drv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c
> b/drivers/gpu/drm/omapdrm/omap_drv.c index 022029e..ce3341d 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -517,7 +517,6 @@ static struct drm_driver omap_drm_driver = {
>  	.gem_vm_ops = &omap_gem_vm_ops,
>  	.dumb_create = omap_gem_dumb_create,
>  	.dumb_map_offset = omap_gem_dumb_map_offset,
> -	.dumb_destroy = drm_gem_dumb_destroy,
>  	.ioctls = ioctls,
>  	.num_ioctls = DRM_OMAP_NUM_IOCTLS,
>  	.fops = &omapdriver_fops,

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel